From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
Damien Le Moal <dlemoal@kernel.org>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH v8 1/9] block: Introduce more member variables related to zone write locking
Date: Fri, 11 Aug 2023 14:35:35 -0700 [thread overview]
Message-ID: <20230811213604.548235-2-bvanassche@acm.org> (raw)
In-Reply-To: <20230811213604.548235-1-bvanassche@acm.org>
Many but not all storage controllers require serialization of zoned writes.
Introduce a new request queue limit member variable
(driver_preserves_write_order) that allows block drivers to indicate that
the order of write commands is preserved and hence that serialization of
writes per zone is not required.
Make disk_set_zoned() set 'use_zone_write_lock' only if the block device
has zones and if the block driver does not preserve the order of write
requests.
Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
block/blk-settings.c | 7 +++++++
include/linux/blkdev.h | 10 ++++++++++
2 files changed, 17 insertions(+)
diff --git a/block/blk-settings.c b/block/blk-settings.c
index 0046b447268f..3a7748af1bef 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -56,6 +56,8 @@ void blk_set_default_limits(struct queue_limits *lim)
lim->alignment_offset = 0;
lim->io_opt = 0;
lim->misaligned = 0;
+ lim->driver_preserves_write_order = false;
+ lim->use_zone_write_lock = false;
lim->zoned = BLK_ZONED_NONE;
lim->zone_write_granularity = 0;
lim->dma_alignment = 511;
@@ -685,6 +687,9 @@ int blk_stack_limits(struct queue_limits *t, struct queue_limits *b,
b->max_secure_erase_sectors);
t->zone_write_granularity = max(t->zone_write_granularity,
b->zone_write_granularity);
+ /* Request-based stacking drivers do not reorder requests. */
+ t->driver_preserves_write_order = b->driver_preserves_write_order;
+ t->use_zone_write_lock = b->use_zone_write_lock;
t->zoned = max(t->zoned, b->zoned);
return ret;
}
@@ -949,6 +954,8 @@ void disk_set_zoned(struct gendisk *disk, enum blk_zoned_model model)
}
q->limits.zoned = model;
+ q->limits.use_zone_write_lock = model != BLK_ZONED_NONE &&
+ !q->limits.driver_preserves_write_order;
if (model != BLK_ZONED_NONE) {
/*
* Set the zone write granularity to the device logical block
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 2f5371b8482c..2c090a28ec78 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -316,6 +316,16 @@ struct queue_limits {
unsigned char misaligned;
unsigned char discard_misaligned;
unsigned char raid_partial_stripes_expensive;
+ /*
+ * Whether or not the block driver preserves the order of write
+ * requests. Set by the block driver.
+ */
+ bool driver_preserves_write_order;
+ /*
+ * Whether or not zone write locking should be used. Set by
+ * disk_set_zoned().
+ */
+ bool use_zone_write_lock;
enum blk_zoned_model zoned;
/*
next prev parent reply other threads:[~2023-08-11 21:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 21:35 [PATCH v8 0/9] Improve performance for zoned UFS devices Bart Van Assche
2023-08-11 21:35 ` Bart Van Assche [this message]
2023-08-14 12:32 ` [PATCH v8 1/9] block: Introduce more member variables related to zone write locking Damien Le Moal
2023-08-14 16:57 ` Bart Van Assche
2023-08-15 2:01 ` Damien Le Moal
2023-08-15 16:06 ` Bart Van Assche
2023-08-11 21:35 ` [PATCH v8 2/9] block/mq-deadline: Only use zone locking if necessary Bart Van Assche
2023-08-14 12:33 ` Damien Le Moal
2023-08-14 17:00 ` Bart Van Assche
2023-08-15 1:57 ` Damien Le Moal
2023-08-11 21:35 ` [PATCH v8 3/9] scsi: core: Call .eh_prepare_resubmit() before resubmitting Bart Van Assche
2023-08-14 1:19 ` Damien Le Moal
2023-08-14 2:18 ` Bart Van Assche
2023-08-14 2:41 ` Damien Le Moal
2023-08-14 3:23 ` Bart Van Assche
2023-08-14 4:18 ` Damien Le Moal
2023-08-14 17:52 ` Bart Van Assche
2023-08-11 21:35 ` [PATCH v8 4/9] scsi: sd: Sort commands by LBA " Bart Van Assche
2023-08-11 21:35 ` [PATCH v8 5/9] scsi: core: Retry unaligned zoned writes Bart Van Assche
2023-08-14 12:36 ` Damien Le Moal
2023-08-14 17:57 ` Bart Van Assche
2023-08-15 1:52 ` Damien Le Moal
2023-08-15 17:29 ` Bart Van Assche
2023-08-16 1:13 ` Damien Le Moal
2023-08-16 19:59 ` Bart Van Assche
2023-08-11 21:35 ` [PATCH v8 6/9] scsi: scsi_debug: Support disabling zone write locking Bart Van Assche
2023-08-11 21:35 ` [PATCH v8 7/9] scsi: scsi_debug: Support injecting unaligned write errors Bart Van Assche
2023-08-11 21:35 ` [PATCH v8 8/9] scsi: ufs: Split an if-condition Bart Van Assche
2023-08-11 21:35 ` [PATCH v8 9/9] scsi: ufs: Inform the block layer about write ordering Bart Van Assche
2023-08-12 17:09 ` Bao D. Nguyen
2023-08-14 16:23 ` Bart Van Assche
2023-08-15 3:20 ` Bao D. Nguyen
2023-08-15 15:41 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811213604.548235-2-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox