public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: jejb@linux.ibm.com, martin.petersen@oracle.com,
	chenxiang66@hisilicon.com, artur.paszkiewicz@intel.com,
	yanaijie@huawei.com, jinpu.wang@cloud.ionos.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	dlemoal@kernel.org, John Garry <john.g.garry@oracle.com>
Subject: [PATCH 08/10] scsi: libsas: Delete sas_ata_task.set_affil_pol
Date: Mon, 14 Aug 2023 14:10:20 +0000	[thread overview]
Message-ID: <20230814141022.36875-9-john.g.garry@oracle.com> (raw)
In-Reply-To: <20230814141022.36875-1-john.g.garry@oracle.com>

Since libsas was introduced in commit 2908d778ab3e ("[SCSI] aic94xx: new
driver"), sas_ata_task.set_affil_pol is never set, so delete it and the
reference in asd_build_ata_ascb().

Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 drivers/scsi/aic94xx/aic94xx_task.c | 7 +++----
 include/scsi/libsas.h               | 1 -
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/aic94xx/aic94xx_task.c b/drivers/scsi/aic94xx/aic94xx_task.c
index f67983e8b262..ca435811c310 100644
--- a/drivers/scsi/aic94xx/aic94xx_task.c
+++ b/drivers/scsi/aic94xx/aic94xx_task.c
@@ -390,11 +390,10 @@ static int asd_build_ata_ascb(struct asd_ascb *ascb, struct sas_task *task,
 
 		scb->ata_task.retry_count = task->ata_task.retry_count;
 
-		flags = 0;
-		if (task->ata_task.set_affil_pol)
-			flags |= SET_AFFIL_POLICY;
 		if (task->ata_task.stp_affil_pol)
-			flags |= STP_AFFIL_POLICY;
+			flags = STP_AFFIL_POLICY;
+		else
+			flags = 0;
 		scb->ata_task.flags = flags;
 	}
 	ascb->tasklet_complete = asd_task_tasklet_complete;
diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
index 5b2e6932c564..3a52094090a1 100644
--- a/include/scsi/libsas.h
+++ b/include/scsi/libsas.h
@@ -529,7 +529,6 @@ struct sas_ata_task {
 
 	u8     dma_xfer:1;	  /* PIO:0 or DMA:1 */
 	u8     use_ncq:1;
-	u8     set_affil_pol:1;
 	u8     stp_affil_pol:1;
 
 	u8     device_control_reg_update:1;
-- 
2.35.3


  parent reply	other threads:[~2023-08-14 14:12 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14 14:10 [PATCH 00/10] libsas: Some tidy-up John Garry
2023-08-14 14:10 ` [PATCH 01/10] scsi: libsas: Delete sas_ha_struct.lldd_module John Garry
2023-08-15  2:07   ` Damien Le Moal
2023-08-15  9:27   ` Jason Yan
2023-10-09  6:38   ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 02/10] scsi: libsas: Delete enum sas_class John Garry
2023-08-15  2:07   ` Damien Le Moal
2023-08-15  9:30   ` Jason Yan
2023-10-09  6:38   ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 03/10] scsi: libsas: Delete enum sas_phy_type John Garry
2023-08-15  2:08   ` Damien Le Moal
2023-08-15  9:30   ` Jason Yan
2023-10-09  6:39   ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 04/10] scsi: libsas: Delete struct scsi_core John Garry
2023-08-15  2:10   ` Damien Le Moal
2023-08-15  9:30   ` Jason Yan
2023-10-09  6:40   ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 05/10] scsi: libsas: Delete sas_ssp_task.retry_count John Garry
2023-08-15  2:10   ` Damien Le Moal
2023-08-15  9:31   ` Jason Yan
2023-10-09  6:41   ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 06/10] scsi: libsas: Delete sas_ssp_task.enable_first_burst John Garry
2023-08-15  2:11   ` Damien Le Moal
2023-08-15  9:34   ` Jason Yan
2023-10-09  6:42   ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 07/10] scsi: libsas: Delete sas_ssp_task.task_prio John Garry
2023-08-15  2:17   ` Damien Le Moal
2023-08-15  7:44     ` John Garry
2023-10-09  6:55   ` Hannes Reinecke
2023-10-24 10:07     ` John Garry
2023-10-24 10:08       ` Hannes Reinecke
2023-08-14 14:10 ` John Garry [this message]
2023-08-15  2:12   ` [PATCH 08/10] scsi: libsas: Delete sas_ata_task.set_affil_pol Damien Le Moal
2023-08-15  9:37   ` Jason Yan
2023-10-09  6:56   ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 09/10] scsi: libsas: Delete sas_ata_task.stp_affil_pol John Garry
2023-08-15  2:13   ` Damien Le Moal
2023-08-15  9:37   ` Jason Yan
2023-10-09  6:57   ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 10/10] scsi: libsas: Delete sas_ata_task.retry_count John Garry
2023-08-15  2:14   ` Damien Le Moal
2023-08-15  9:37   ` Jason Yan
2023-10-09  6:57   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230814141022.36875-9-john.g.garry@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=artur.paszkiewicz@intel.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=dlemoal@kernel.org \
    --cc=jejb@linux.ibm.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox