From: Brian Masney <bmasney@redhat.com>
To: jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
hugo@hugovil.com, quic_nguyenb@quicinc.com
Subject: [PATCH v3 2/2] scsi: ufs: host: convert to dev_err_probe() in pltfrm_init
Date: Mon, 14 Aug 2023 14:43:52 -0400 [thread overview]
Message-ID: <20230814184352.200531-3-bmasney@redhat.com> (raw)
In-Reply-To: <20230814184352.200531-1-bmasney@redhat.com>
Convert ufshcd_pltfrm_init() over to use dev_err_probe() to avoid
the following log message on bootup due to an -EPROBE_DEFER return
code:
ufshcd-qcom 1d84000.ufs: Initialization failed
While this line is changed, let's also go ahead and add the error code
to the message as well.
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
Changes since v2
- Add error code to message
Changes since v1
- None
drivers/ufs/host/ufshcd-pltfrm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c
index 0b7430033047..c81a14f9eaf5 100644
--- a/drivers/ufs/host/ufshcd-pltfrm.c
+++ b/drivers/ufs/host/ufshcd-pltfrm.c
@@ -373,7 +373,8 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
err = ufshcd_init(hba, mmio_base, irq);
if (err) {
- dev_err(dev, "Initialization failed\n");
+ dev_err_probe(dev, err, "Initialization failed with error %d\n",
+ err);
goto dealloc_host;
}
--
2.41.0
next prev parent reply other threads:[~2023-08-14 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 18:43 [PATCH v3 0/2] scsi: ufs: convert probe to use dev_err_probe() Brian Masney
2023-08-14 18:43 ` [PATCH v3 1/2] scsi: ufs: core: convert to dev_err_probe() in hba_init Brian Masney
2023-08-14 19:31 ` Bart Van Assche
2023-08-14 21:18 ` Brian Masney
2023-08-14 21:24 ` Bart Van Assche
2023-08-14 18:43 ` Brian Masney [this message]
2023-08-15 3:25 ` [PATCH v3 2/2] scsi: ufs: host: convert to dev_err_probe() in pltfrm_init Bao D. Nguyen
2023-08-21 20:45 ` [PATCH v3 0/2] scsi: ufs: convert probe to use dev_err_probe() Martin K. Petersen
2023-08-25 1:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814184352.200531-3-bmasney@redhat.com \
--to=bmasney@redhat.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=hugo@hugovil.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_nguyenb@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox