Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: jejb@linux.ibm.com, martin.petersen@oracle.com,
	chenxiang66@hisilicon.com, artur.paszkiewicz@intel.com,
	yanaijie@huawei.com, jinpu.wang@cloud.ionos.com,
	dlemoal@kernel.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	John Garry <john.g.garry@oracle.com>
Subject: [PATCH v2 09/10] scsi: libsas: Delete sas_ata_task.stp_affil_pol
Date: Tue, 15 Aug 2023 11:51:55 +0000	[thread overview]
Message-ID: <20230815115156.343535-10-john.g.garry@oracle.com> (raw)
In-Reply-To: <20230815115156.343535-1-john.g.garry@oracle.com>

Since libsas was introduced in commit 2908d778ab3e ("[SCSI] aic94xx: new
driver"), sas_ata_task.stp_affil_pol is never set, so delete it and the
reference in asd_build_ata_ascb().

Signed-off-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/scsi/aic94xx/aic94xx_task.c | 6 +-----
 include/scsi/libsas.h               | 1 -
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/scsi/aic94xx/aic94xx_task.c b/drivers/scsi/aic94xx/aic94xx_task.c
index ca435811c310..21b69e592664 100644
--- a/drivers/scsi/aic94xx/aic94xx_task.c
+++ b/drivers/scsi/aic94xx/aic94xx_task.c
@@ -390,11 +390,7 @@ static int asd_build_ata_ascb(struct asd_ascb *ascb, struct sas_task *task,
 
 		scb->ata_task.retry_count = task->ata_task.retry_count;
 
-		if (task->ata_task.stp_affil_pol)
-			flags = STP_AFFIL_POLICY;
-		else
-			flags = 0;
-		scb->ata_task.flags = flags;
+		scb->ata_task.flags = 0;
 	}
 	ascb->tasklet_complete = asd_task_tasklet_complete;
 
diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
index 3a52094090a1..a65c16643315 100644
--- a/include/scsi/libsas.h
+++ b/include/scsi/libsas.h
@@ -529,7 +529,6 @@ struct sas_ata_task {
 
 	u8     dma_xfer:1;	  /* PIO:0 or DMA:1 */
 	u8     use_ncq:1;
-	u8     stp_affil_pol:1;
 
 	u8     device_control_reg_update:1;
 
-- 
2.31.1


  parent reply	other threads:[~2023-08-15 11:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 11:51 [PATCH v2 00/10] libsas: Some tidy-up John Garry
2023-08-15 11:51 ` [PATCH v2 01/10] scsi: libsas: Delete sas_ha_struct.lldd_module John Garry
2023-08-15 11:51 ` [PATCH v2 02/10] scsi: libsas: Delete enum sas_class John Garry
2023-08-15 11:51 ` [PATCH v2 03/10] scsi: libsas: Delete enum sas_phy_type John Garry
2023-08-15 11:51 ` [PATCH v2 04/10] scsi: libsas: Delete struct scsi_core John Garry
2023-08-15 11:51 ` [PATCH v2 05/10] scsi: libsas: Delete sas_ssp_task.retry_count John Garry
2023-08-15 11:51 ` [PATCH v2 06/10] scsi: libsas: Delete sas_ssp_task.enable_first_burst John Garry
2023-08-15 11:51 ` [PATCH v2 07/10] scsi: libsas: Delete sas_ssp_task.task_prio John Garry
2023-08-15 12:42   ` Damien Le Moal
2023-08-16  2:41   ` Jason Yan
2023-08-15 11:51 ` [PATCH v2 08/10] scsi: libsas: Delete sas_ata_task.set_affil_pol John Garry
2023-08-15 11:51 ` John Garry [this message]
2023-08-15 11:51 ` [PATCH v2 10/10] scsi: libsas: Delete sas_ata_task.retry_count John Garry
2023-08-21 22:16 ` [PATCH v2 00/10] libsas: Some tidy-up Martin K. Petersen
2023-08-25  1:12 ` Martin K. Petersen
2023-08-31  1:48 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230815115156.343535-10-john.g.garry@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=artur.paszkiewicz@intel.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=dlemoal@kernel.org \
    --cc=jejb@linux.ibm.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox