From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Chengfeng Ye <dg573847474@gmail.com>
Cc: hare@suse.de, jejb@linux.ibm.com, martin.petersen@oracle.com,
dave@stgolabs.net, satishkh@cisco.com, sebaddel@cisco.com,
kartilak@cisco.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock
Date: Thu, 17 Aug 2023 08:52:11 +0200 [thread overview]
Message-ID: <20230817065211.ajz8zcev@linutronix.de> (raw)
In-Reply-To: <20230816155524.5913-1-dg573847474@gmail.com>
On 2023-08-16 15:55:24 [+0000], Chengfeng Ye wrote:
> These flaws were found by an experimental static analysis tool I am
> developing for irq-related deadlock.
So you did not use lockdep or is the code path so unlikely that nobody
stumbled upon it before?
> The patch fix the potential deadlocks by spin_lock_irqsave() to
> disable hard irq.
Shouldn't this have
Fixes: 794d98e77f590 ("[SCSI] libfcoe: retry rejected FLOGI to another FCF if possible")
?
> Signed-off-by: Chengfeng Ye <dg573847474@gmail.com>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
next prev parent reply other threads:[~2023-08-17 6:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 15:55 [PATCH RESEND] scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock Chengfeng Ye
2023-08-16 15:57 ` Chengfeng Ye
2023-08-16 17:10 ` Hannes Reinecke
2023-08-16 17:11 ` Chengfeng Ye
2023-08-17 6:52 ` Sebastian Andrzej Siewior [this message]
2023-08-17 7:48 ` Chengfeng Ye
2023-08-17 14:24 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817065211.ajz8zcev@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=dave@stgolabs.net \
--cc=dg573847474@gmail.com \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox