From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA788CD4847 for ; Fri, 22 Sep 2023 18:24:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233300AbjIVSYH (ORCPT ); Fri, 22 Sep 2023 14:24:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233287AbjIVSYF (ORCPT ); Fri, 22 Sep 2023 14:24:05 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38796FB; Fri, 22 Sep 2023 11:23:59 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2577C433C8; Fri, 22 Sep 2023 18:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695407038; bh=RRQu2DA14XEsOavEYlHhXKY49cxRSB7CmCyQBdCxHsI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vt7kTBkEKWFfO5XRpzx3MKYN6JXRa3iKFBaOej4PW93d6qyYji0JQB24eFF7nAUTn aTUuIM1SSFKHU0qc6T62YQNfsSGywaoVqU/PDZvPRv4nPhWtKpRbyNl4JjiqIdVlFj MGM51PE+7PeQXBMaIzpIkaZ2FT2C7+zSYT644q0E4RrTZHwVf97zQVLUbeCrOWeyM5 8Eyc/sK2T9XWgAkelq9E3ZPX1RX7f08WgwKfxHBXASSvqzbjx0hYNv1EXR07m9YvIu UM0SYVkgVxuHjWq/7hK0sioaL7KuRcnPmISLoglHmY9vYhGKrlkLUY5I69qq+gRvDE n0WnYi4Db29Nw== Date: Fri, 22 Sep 2023 20:23:50 +0200 From: Manivannan Sadhasivam To: Bjorn Andersson Cc: Manivannan Sadhasivam , Dmitry Baryshkov , Can Guo , quic_nguyenb@quicinc.com, quic_nitirawa@quicinc.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , open list , "open list:ARM/QUALCOMM SUPPORT" , "open list:GENERIC PHY FRAMEWORK" Subject: Re: [PATCH 4/6] phy: qualcomm: phy-qcom-qmp-ufs: Move data structs and setting tables to header Message-ID: <20230922182350.GA3381@thinkpad> References: <1694411968-14413-1-git-send-email-quic_cang@quicinc.com> <1694411968-14413-5-git-send-email-quic_cang@quicinc.com> <20230919121524.GD4732@thinkpad> <20230920101923.GG4732@thinkpad> <20230921140220.GK1487598@hu-bjorande-lv.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230921140220.GK1487598@hu-bjorande-lv.qualcomm.com> Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Thu, Sep 21, 2023 at 07:02:20AM -0700, Bjorn Andersson wrote: > On Wed, Sep 20, 2023 at 12:19:23PM +0200, Manivannan Sadhasivam wrote: > [..] > > Btw, why do we have "phy-qcom" prefix inside drivers/phy/qualcomm/? > > > > That would be a historical artifact, but it does provide nice > namespacing for the generated .ko files - and iirc mkinitcpio doesn't > automatically pick these up, so changing it would cause issues for our > users. > Well, my concern is only with the driver name and not with the module name. And yes, module name should have the proper prefix (unlike "msm" for the DRM module). - Mani > Regards, > Bjorn -- மணிவண்ணன் சதாசிவம்