* [PATCH v1] ufs: core: correct clear tm error log
@ 2023-10-02 12:55 peter.wang
2023-10-02 18:44 ` Avri Altman
2023-10-02 20:33 ` Bart Van Assche
0 siblings, 2 replies; 4+ messages in thread
From: peter.wang @ 2023-10-02 12:55 UTC (permalink / raw)
To: stanley.chu, linux-scsi, martin.petersen, avri.altman,
alim.akhtar, jejb
Cc: wsd_upstream, linux-mediatek, peter.wang, chun-hung.wu,
alice.chao, cc.chou, chaotian.jing, jiajie.hao, powen.kao,
qilin.tan, lin.gui, tun-yu.yu, eddie.huang, naomi.chu
From: Peter Wang <peter.wang@mediatek.com>
The clear tm function error log is inverted.
Signed-off-by: Peter Wang <peter.wang@mediatek.com>
---
drivers/ufs/core/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index c2df07545f96..4095d88eee44 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -6895,7 +6895,7 @@ static int ufshcd_clear_tm_cmd(struct ufs_hba *hba, int tag)
mask, 0, 1000, 1000);
dev_err(hba->dev, "Clearing task management function with tag %d %s\n",
- tag, err ? "succeeded" : "failed");
+ tag, err ? "failed" : "succeeded");
out:
return err;
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH v1] ufs: core: correct clear tm error log
2023-10-02 12:55 [PATCH v1] ufs: core: correct clear tm error log peter.wang
@ 2023-10-02 18:44 ` Avri Altman
2023-10-02 20:33 ` Bart Van Assche
1 sibling, 0 replies; 4+ messages in thread
From: Avri Altman @ 2023-10-02 18:44 UTC (permalink / raw)
To: peter.wang@mediatek.com, stanley.chu@mediatek.com,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org,
chun-hung.wu@mediatek.com, alice.chao@mediatek.com,
cc.chou@mediatek.com, chaotian.jing@mediatek.com,
jiajie.hao@mediatek.com, powen.kao@mediatek.com,
qilin.tan@mediatek.com, lin.gui@mediatek.com,
tun-yu.yu@mediatek.com, eddie.huang@mediatek.com,
naomi.chu@mediatek.com
> From: Peter Wang <peter.wang@mediatek.com>
>
> The clear tm function error log is inverted.
>
> Signed-off-by: Peter Wang <peter.wang@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
> ---
> drivers/ufs/core/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index
> c2df07545f96..4095d88eee44 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -6895,7 +6895,7 @@ static int ufshcd_clear_tm_cmd(struct ufs_hba
> *hba, int tag)
> mask, 0, 1000, 1000);
>
> dev_err(hba->dev, "Clearing task management function with tag %d
> %s\n",
> - tag, err ? "succeeded" : "failed");
> + tag, err ? "failed" : "succeeded");
>
> out:
> return err;
> --
> 2.18.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] ufs: core: correct clear tm error log
2023-10-02 12:55 [PATCH v1] ufs: core: correct clear tm error log peter.wang
2023-10-02 18:44 ` Avri Altman
@ 2023-10-02 20:33 ` Bart Van Assche
2023-10-03 2:18 ` Peter Wang (王信友)
1 sibling, 1 reply; 4+ messages in thread
From: Bart Van Assche @ 2023-10-02 20:33 UTC (permalink / raw)
To: peter.wang, stanley.chu, linux-scsi, martin.petersen, avri.altman,
alim.akhtar, jejb
Cc: wsd_upstream, linux-mediatek, chun-hung.wu, alice.chao, cc.chou,
chaotian.jing, jiajie.hao, powen.kao, qilin.tan, lin.gui,
tun-yu.yu, eddie.huang, naomi.chu
On 10/2/23 05:55, peter.wang@mediatek.com wrote:
> From: Peter Wang <peter.wang@mediatek.com>
>
> The clear tm function error log is inverted.
>
> Signed-off-by: Peter Wang <peter.wang@mediatek.com>
> ---
> drivers/ufs/core/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index c2df07545f96..4095d88eee44 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -6895,7 +6895,7 @@ static int ufshcd_clear_tm_cmd(struct ufs_hba *hba, int tag)
> mask, 0, 1000, 1000);
>
> dev_err(hba->dev, "Clearing task management function with tag %d %s\n",
> - tag, err ? "succeeded" : "failed");
> + tag, err ? "failed" : "succeeded");
>
> out:
> return err;
Please consider changing "err ?" into "err < 0 ?" to make it more clear
that negative return values represent an error. Additionally, please
consider adding the following:
Fixes: 4693fad7d6d4 ("scsi: ufs: core: Log error handler activity")
Thanks,
Bart.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] ufs: core: correct clear tm error log
2023-10-02 20:33 ` Bart Van Assche
@ 2023-10-03 2:18 ` Peter Wang (王信友)
0 siblings, 0 replies; 4+ messages in thread
From: Peter Wang (王信友) @ 2023-10-03 2:18 UTC (permalink / raw)
To: linux-scsi@vger.kernel.org, bvanassche@acm.org,
avri.altman@wdc.com, Stanley Chu (朱原陞),
alim.akhtar@samsung.com, martin.petersen@oracle.com,
jejb@linux.ibm.com
Cc: linux-mediatek@lists.infradead.org,
Jiajie Hao (郝加节),
CC Chou (周志杰),
Eddie Huang (黃智傑),
Alice Chao (趙珮均), wsd_upstream,
Lin Gui (桂林),
Chun-Hung Wu (巫駿宏),
Tun-yu Yu (游敦聿),
Chaotian Jing (井朝天),
Powen Kao (高伯文),
Naomi Chu (朱詠田),
Qilin Tan (谭麒麟)
On Mon, 2023-10-02 at 13:33 -0700, Bart Van Assche wrote:
> Please consider changing "err ?" into "err < 0 ?" to make it more
> clear
> that negative return values represent an error. Additionally, please
> consider adding the following:
>
> Fixes: 4693fad7d6d4 ("scsi: ufs: core: Log error handler activity")
>
> Thanks,
>
> Bart.
Hi Bart,
Thanks for review and good suggestion. will update next version.
Thanks.
Peter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-03 2:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-02 12:55 [PATCH v1] ufs: core: correct clear tm error log peter.wang
2023-10-02 18:44 ` Avri Altman
2023-10-02 20:33 ` Bart Van Assche
2023-10-03 2:18 ` Peter Wang (王信友)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox