From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH 14/15] fnic: use fc_block_rport() correctly
Date: Mon, 2 Oct 2023 17:49:26 +0200 [thread overview]
Message-ID: <20231002154927.68643-15-hare@suse.de> (raw)
In-Reply-To: <20231002154927.68643-1-hare@suse.de>
Use fc_block_rport() instead of fc_block_scsi_eh() and evaluate
the return value to avoid issuing TMF commands when the port
is still blocked.
Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
drivers/scsi/fnic/fnic_scsi.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index 72352ac89eab..25af91081baf 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -1719,9 +1719,6 @@ int fnic_abort_cmd(struct scsi_cmnd *sc)
unsigned long abt_issued_time;
DECLARE_COMPLETION_ONSTACK(tm_done);
- /* Wait for rport to unblock */
- fc_block_scsi_eh(sc);
-
/* Get local-port, check ready and link up */
lp = shost_priv(sc->device->host);
@@ -1731,6 +1728,10 @@ int fnic_abort_cmd(struct scsi_cmnd *sc)
term_stats = &fnic->fnic_stats.term_stats;
rport = starget_to_rport(scsi_target(sc->device));
+ ret = fc_block_rport(rport);
+ if (ret)
+ return ret;
+
FNIC_SCSI_DBG(KERN_DEBUG,
fnic->lport->host,
"Abort Cmd called FCID 0x%x, LUN 0x%llx TAG %x flags %x\n",
--
2.35.3
next prev parent reply other threads:[~2023-10-02 15:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 15:49 [PATCHv500/15] scsi: EH rework prep patches, part 2 Hannes Reinecke
2023-10-02 15:49 ` [PATCH 01/15] zfcp: do not wait for rports to become unblocked after host reset Hannes Reinecke
2023-10-12 13:54 ` Benjamin Block
2023-10-12 14:23 ` Hannes Reinecke
2023-10-12 17:49 ` Benjamin Block
2023-10-13 6:18 ` Hannes Reinecke
2023-10-02 15:49 ` [PATCH 02/15] bfa: Do not use scsi command to signal TMF status Hannes Reinecke
2023-10-02 15:49 ` [PATCH 03/15] aha152x: look for stuck command when resetting device Hannes Reinecke
2023-10-02 15:49 ` [PATCH 04/15] a1000u2w: do not rely on the command for inia100_device_reset() Hannes Reinecke
2023-10-02 15:49 ` [PATCH 05/15] fas216: Rework device reset to not rely on SCSI command pointer Hannes Reinecke
2023-10-02 15:49 ` [PATCH 06/15] xen-scsifront: add scsi device as argument to scsifront_do_request() Hannes Reinecke
2023-10-02 15:49 ` [PATCH 07/15] xen-scsifront: rework scsifront_action_handler() Hannes Reinecke
2023-10-02 15:49 ` [PATCH 08/15] libiscsi: use cls_session as argument for target and session reset Hannes Reinecke
2023-10-02 15:49 ` [PATCH 09/15] scsi_transport_iscsi: use session as argument for iscsi_block_scsi_eh() Hannes Reinecke
2023-10-02 15:49 ` [PATCH 10/15] snic: reserve tag for TMF Hannes Reinecke
2023-10-02 15:49 ` [PATCH 11/15] snic: allocate device reset command Hannes Reinecke
2023-10-02 15:49 ` [PATCH 12/15] snic: Use scsi_host_busy_iter() to traverse commands Hannes Reinecke
2023-10-02 15:49 ` [PATCH 13/15] fnic: allocate device reset command on the fly Hannes Reinecke
2023-10-02 15:49 ` Hannes Reinecke [this message]
2023-10-02 15:49 ` [PATCH 15/15] csiostor: use separate TMF command Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002154927.68643-15-hare@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox