* [PATCH v2] ufs: core: correct clear tm error log
@ 2023-10-03 2:20 peter.wang
2023-10-03 17:28 ` Bart Van Assche
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: peter.wang @ 2023-10-03 2:20 UTC (permalink / raw)
To: stanley.chu, linux-scsi, martin.petersen, avri.altman,
alim.akhtar, jejb
Cc: wsd_upstream, linux-mediatek, peter.wang, chun-hung.wu,
alice.chao, cc.chou, chaotian.jing, jiajie.hao, powen.kao,
qilin.tan, lin.gui, tun-yu.yu, eddie.huang, naomi.chu
From: Peter Wang <peter.wang@mediatek.com>
The clear tm function error log is inverted.
Fixes: 4693fad7d6d4 ("scsi: ufs: core: Log error handler activity")
Signed-off-by: Peter Wang <peter.wang@mediatek.com>
---
drivers/ufs/core/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index c2df07545f96..8382e8cfa414 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -6895,7 +6895,7 @@ static int ufshcd_clear_tm_cmd(struct ufs_hba *hba, int tag)
mask, 0, 1000, 1000);
dev_err(hba->dev, "Clearing task management function with tag %d %s\n",
- tag, err ? "succeeded" : "failed");
+ tag, err < 0 ? "failed" : "succeeded");
out:
return err;
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] ufs: core: correct clear tm error log
2023-10-03 2:20 [PATCH v2] ufs: core: correct clear tm error log peter.wang
@ 2023-10-03 17:28 ` Bart Van Assche
2023-10-04 1:31 ` Stanley Chu
2023-10-10 2:09 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2023-10-03 17:28 UTC (permalink / raw)
To: peter.wang, stanley.chu, linux-scsi, martin.petersen, avri.altman,
alim.akhtar, jejb
Cc: wsd_upstream, linux-mediatek, chun-hung.wu, alice.chao, cc.chou,
chaotian.jing, jiajie.hao, powen.kao, qilin.tan, lin.gui,
tun-yu.yu, eddie.huang, naomi.chu
On 10/2/23 19:20, peter.wang@mediatek.com wrote:
> The clear tm function error log is inverted.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ufs: core: correct clear tm error log
2023-10-03 2:20 [PATCH v2] ufs: core: correct clear tm error log peter.wang
2023-10-03 17:28 ` Bart Van Assche
@ 2023-10-04 1:31 ` Stanley Chu
2023-10-10 2:09 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Stanley Chu @ 2023-10-04 1:31 UTC (permalink / raw)
To: peter.wang
Cc: stanley.chu, linux-scsi, martin.petersen, avri.altman,
alim.akhtar, jejb, wsd_upstream, linux-mediatek, chun-hung.wu,
alice.chao, cc.chou, chaotian.jing, jiajie.hao, powen.kao,
qilin.tan, lin.gui, tun-yu.yu, eddie.huang, naomi.chu
On Tue, Oct 3, 2023 at 10:20 AM <peter.wang@mediatek.com> wrote:
>
> From: Peter Wang <peter.wang@mediatek.com>
>
> The clear tm function error log is inverted.
>
> Fixes: 4693fad7d6d4 ("scsi: ufs: core: Log error handler activity")
> Signed-off-by: Peter Wang <peter.wang@mediatek.com>
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] ufs: core: correct clear tm error log
2023-10-03 2:20 [PATCH v2] ufs: core: correct clear tm error log peter.wang
2023-10-03 17:28 ` Bart Van Assche
2023-10-04 1:31 ` Stanley Chu
@ 2023-10-10 2:09 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-10-10 2:09 UTC (permalink / raw)
To: stanley.chu, linux-scsi, avri.altman, alim.akhtar, jejb,
peter.wang
Cc: Martin K . Petersen, wsd_upstream, linux-mediatek, chun-hung.wu,
alice.chao, cc.chou, chaotian.jing, jiajie.hao, powen.kao,
qilin.tan, lin.gui, tun-yu.yu, eddie.huang, naomi.chu
On Tue, 03 Oct 2023 10:20:02 +0800, peter.wang@mediatek.com wrote:
> The clear tm function error log is inverted.
>
>
Applied to 6.6/scsi-fixes, thanks!
[1/1] ufs: core: correct clear tm error log
https://git.kernel.org/mkp/scsi/c/a20c4350c6a1
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-10 2:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-03 2:20 [PATCH v2] ufs: core: correct clear tm error log peter.wang
2023-10-03 17:28 ` Bart Van Assche
2023-10-04 1:31 ` Stanley Chu
2023-10-10 2:09 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox