* [PATCH] scsi: ufs: qcom: remove unnecessary check
@ 2023-10-02 7:03 Dan Carpenter
2023-10-10 1:53 ` Martin K. Petersen
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2023-10-02 7:03 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, James E.J. Bottomley,
Martin K. Petersen, linux-arm-msm, linux-scsi, kernel-janitors
The "attr" pointer points to an offset into the "host" struct so it
can't be NULL. Delete the if statement and pull the code in a tab.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/ufs/host/ufs-qcom.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 2128db0293b5..96cb8b5b4e66 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -1447,15 +1447,11 @@ static int ufs_qcom_clk_scale_up_pre_change(struct ufs_hba *hba)
if (!ufs_qcom_cap_qunipro(host))
return 0;
- if (attr) {
- ret = ufs_qcom_cfg_timers(hba, attr->gear_rx,
- attr->pwr_rx, attr->hs_rate,
- false, true);
- if (ret) {
- dev_err(hba->dev, "%s ufs cfg timer failed\n",
- __func__);
- return ret;
- }
+ ret = ufs_qcom_cfg_timers(hba, attr->gear_rx, attr->pwr_rx,
+ attr->hs_rate, false, true);
+ if (ret) {
+ dev_err(hba->dev, "%s ufs cfg timer failed\n", __func__);
+ return ret;
}
/* set unipro core clock attributes and clear clock divider */
return ufs_qcom_set_core_clk_ctrl(hba, true);
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: ufs: qcom: remove unnecessary check
2023-10-02 7:03 [PATCH] scsi: ufs: qcom: remove unnecessary check Dan Carpenter
@ 2023-10-10 1:53 ` Martin K. Petersen
2023-10-10 12:21 ` Manivannan Sadhasivam
2023-10-13 21:03 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-10-10 1:53 UTC (permalink / raw)
To: Dan Carpenter
Cc: Manivannan Sadhasivam, Andy Gross, Bjorn Andersson, Konrad Dybcio,
James E.J. Bottomley, Martin K. Petersen, linux-arm-msm,
linux-scsi, kernel-janitors
Dan,
> The "attr" pointer points to an offset into the "host" struct so it
> can't be NULL. Delete the if statement and pull the code in a tab.
Applied to 6.7/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: qcom: remove unnecessary check
2023-10-02 7:03 [PATCH] scsi: ufs: qcom: remove unnecessary check Dan Carpenter
2023-10-10 1:53 ` Martin K. Petersen
@ 2023-10-10 12:21 ` Manivannan Sadhasivam
2023-10-13 21:03 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2023-10-10 12:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, James E.J. Bottomley,
Martin K. Petersen, linux-arm-msm, linux-scsi, kernel-janitors
On Mon, Oct 02, 2023 at 10:03:35AM +0300, Dan Carpenter wrote:
> The "attr" pointer points to an offset into the "host" struct so it
> can't be NULL. Delete the if statement and pull the code in a tab.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/ufs/host/ufs-qcom.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 2128db0293b5..96cb8b5b4e66 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1447,15 +1447,11 @@ static int ufs_qcom_clk_scale_up_pre_change(struct ufs_hba *hba)
> if (!ufs_qcom_cap_qunipro(host))
> return 0;
>
> - if (attr) {
> - ret = ufs_qcom_cfg_timers(hba, attr->gear_rx,
> - attr->pwr_rx, attr->hs_rate,
> - false, true);
> - if (ret) {
> - dev_err(hba->dev, "%s ufs cfg timer failed\n",
> - __func__);
> - return ret;
> - }
> + ret = ufs_qcom_cfg_timers(hba, attr->gear_rx, attr->pwr_rx,
> + attr->hs_rate, false, true);
> + if (ret) {
> + dev_err(hba->dev, "%s ufs cfg timer failed\n", __func__);
> + return ret;
> }
> /* set unipro core clock attributes and clear clock divider */
> return ufs_qcom_set_core_clk_ctrl(hba, true);
> --
> 2.39.2
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: ufs: qcom: remove unnecessary check
2023-10-02 7:03 [PATCH] scsi: ufs: qcom: remove unnecessary check Dan Carpenter
2023-10-10 1:53 ` Martin K. Petersen
2023-10-10 12:21 ` Manivannan Sadhasivam
@ 2023-10-13 21:03 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-10-13 21:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Dan Carpenter
Cc: Martin K . Petersen, Andy Gross, Bjorn Andersson, Konrad Dybcio,
James E.J. Bottomley, linux-arm-msm, linux-scsi, kernel-janitors
On Mon, 02 Oct 2023 10:03:35 +0300, Dan Carpenter wrote:
> The "attr" pointer points to an offset into the "host" struct so it
> can't be NULL. Delete the if statement and pull the code in a tab.
>
>
Applied to 6.7/scsi-queue, thanks!
[1/1] scsi: ufs: qcom: remove unnecessary check
https://git.kernel.org/mkp/scsi/c/b6f2e063017b
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-13 21:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-02 7:03 [PATCH] scsi: ufs: qcom: remove unnecessary check Dan Carpenter
2023-10-10 1:53 ` Martin K. Petersen
2023-10-10 12:21 ` Manivannan Sadhasivam
2023-10-13 21:03 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).