From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 5/9] scsi: set host byte after EH completed
Date: Tue, 17 Oct 2023 09:25:29 +0200 [thread overview]
Message-ID: <20231017072529.GA11484@lst.de> (raw)
In-Reply-To: <20231016121542.111501-6-hare@suse.de>
On Mon, Oct 16, 2023 at 02:15:38PM +0200, Hannes Reinecke wrote:
> When SCSI EH completes we should be setting the host byte to
> DID_ABORT, DID_RESET, or DID_TRANSPORT_DISRUPTED to inform
> the caller that some EH processing has happened.
I have a hard time following this commit log. Yes, we probably
should. But so far we haven't, so why is this suddenly a problem?
> -void scsi_eh_finish_cmd(struct scsi_cmnd *scmd, struct list_head *done_q)
> +void __scsi_eh_finish_cmd(struct scsi_cmnd *scmd, struct list_head *done_q,
> + int host_byte)
> {
> + if (host_byte)
> + set_host_byte(scmd, host_byte);
> list_move_tail(&scmd->eh_entry, done_q);
What is the point of passing in the host_byte vs just setting it in
the caller?
In fat I'm not even quite sure what the point of the existing helper
is, as moving the command to the passed in queue doesn't provide
much of a useful abstraction.
next prev parent reply other threads:[~2023-10-17 7:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 12:15 [PATCHv6 0/9] scsi: EH rework, main part Hannes Reinecke
2023-10-16 12:15 ` [PATCH 1/9] scsi: Use Scsi_Host as argument for eh_host_reset_handler Hannes Reinecke
2023-10-17 6:40 ` Christoph Hellwig
2023-10-17 8:16 ` Wenchao Hao
2023-10-18 18:20 ` Bart Van Assche
2023-10-23 8:39 ` Hannes Reinecke
2023-10-16 12:15 ` [PATCH 2/9] scsi: Use Scsi_Host and channel number as argument for eh_bus_reset_handler() Hannes Reinecke
2023-10-17 6:40 ` Christoph Hellwig
2023-10-16 12:15 ` [PATCH 3/9] scsi: Use scsi_target as argument for eh_target_reset_handler() Hannes Reinecke
2023-10-17 6:40 ` Christoph Hellwig
2023-10-16 12:15 ` [PATCH 4/9] scsi: Use scsi_device as argument to eh_device_reset_handler() Hannes Reinecke
2023-10-17 6:41 ` Christoph Hellwig
2023-10-17 14:07 ` Wenchao Hao
2023-10-16 12:15 ` [PATCH 5/9] scsi: set host byte after EH completed Hannes Reinecke
2023-10-16 13:59 ` Johannes Thumshirn
2023-10-17 7:13 ` Hannes Reinecke
2023-10-17 7:25 ` Christoph Hellwig [this message]
2023-10-17 8:14 ` Hannes Reinecke
2023-10-18 5:46 ` Christoph Hellwig
2023-10-19 20:30 ` Mike Christie
2023-10-20 5:55 ` Hannes Reinecke
2023-10-16 12:15 ` [PATCH 6/9] scsi_error: iterate over list of failed commands in scsi_eh_bus_reset() Hannes Reinecke
2023-10-17 7:28 ` Christoph Hellwig
2023-10-16 12:15 ` [PATCH 7/9] scsi: Do not allocate scsi command in scsi_ioctl_reset() Hannes Reinecke
2023-10-17 7:18 ` Christoph Hellwig
2023-10-16 12:15 ` [PATCH 8/9] scsi_error: iterate over list of failed commands in scsi_eh_bus_device_reset() Hannes Reinecke
2023-10-17 7:29 ` Christoph Hellwig
2023-10-16 12:15 ` [PATCH 9/9] scsi: remove SUBMITTED_BY_SCSI_RESET_IOCTL Hannes Reinecke
2023-10-17 7:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017072529.GA11484@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox