From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5E8ACDB474 for ; Tue, 17 Oct 2023 07:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234575AbjJQHbW (ORCPT ); Tue, 17 Oct 2023 03:31:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234539AbjJQHbU (ORCPT ); Tue, 17 Oct 2023 03:31:20 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E03C95 for ; Tue, 17 Oct 2023 00:31:19 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id AE34E68D07; Tue, 17 Oct 2023 09:31:14 +0200 (CEST) Date: Tue, 17 Oct 2023 09:31:14 +0200 From: Christoph Hellwig To: Hannes Reinecke Cc: "Martin K. Petersen" , Christoph Hellwig , James Bottomley , linux-scsi@vger.kernel.org Subject: Re: [PATCH] pmcraid: add missing scsi_device_put() in pmcraid_eh_target_reset_handler() Message-ID: <20231017073113.GA12422@lst.de> References: <20231017072145.120795-1-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231017072145.120795-1-hare@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Tue, Oct 17, 2023 at 09:21:45AM +0200, Hannes Reinecke wrote: > (Re-sending as a separate patch:) > When breaking out of a shost_for_each_device() loop one need to do > an explicit scsi_device_put(). And while at it convert to use > shost_priv() instead of a direct reference to ->hostdata. This is still doing two entirely different things. Please send just the trivial scsi_device_put patch as a fix, and the cleanup on top.