Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@lst.de>,
	Bart Van Assche <bvanassche@acm.org>,
	Douglas Gilbert <dgilbert@interlog.com>,
	Damien Le Moal <dlemoal@kernel.org>,
	Ming Lei <ming.lei@redhat.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: [PATCH v13 11/18] scsi: scsi_debug: Add the preserves_write_order module parameter
Date: Wed, 18 Oct 2023 10:54:33 -0700	[thread overview]
Message-ID: <20231018175602.2148415-12-bvanassche@acm.org> (raw)
In-Reply-To: <20231018175602.2148415-1-bvanassche@acm.org>

Zone write locking is not used for zoned devices if the block driver
reports that it preserves the order of write commands. Make it easier to
test not using zone write locking by adding support for setting the
driver_preserves_write_order flag.

Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/scsi/scsi_debug.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 9c0af50501f9..1ea4925d2c2f 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -832,6 +832,7 @@ static int dix_reads;
 static int dif_errors;
 
 /* ZBC global data */
+static bool sdeb_preserves_write_order;
 static bool sdeb_zbc_in_use;	/* true for host-aware and host-managed disks */
 static int sdeb_zbc_zone_cap_mb;
 static int sdeb_zbc_zone_size_mb;
@@ -5138,9 +5139,13 @@ static struct sdebug_dev_info *find_build_dev_info(struct scsi_device *sdev)
 
 static int scsi_debug_slave_alloc(struct scsi_device *sdp)
 {
+	struct request_queue *q = sdp->request_queue;
+
 	if (sdebug_verbose)
 		pr_info("slave_alloc <%u %u %u %llu>\n",
 		       sdp->host->host_no, sdp->channel, sdp->id, sdp->lun);
+	if (sdeb_preserves_write_order)
+		q->limits.driver_preserves_write_order = true;
 	return 0;
 }
 
@@ -5755,6 +5760,8 @@ module_param_named(statistics, sdebug_statistics, bool, S_IRUGO | S_IWUSR);
 module_param_named(strict, sdebug_strict, bool, S_IRUGO | S_IWUSR);
 module_param_named(submit_queues, submit_queues, int, S_IRUGO);
 module_param_named(poll_queues, poll_queues, int, S_IRUGO);
+module_param_named(preserves_write_order, sdeb_preserves_write_order, bool,
+		   S_IRUGO);
 module_param_named(tur_ms_to_ready, sdeb_tur_ms_to_ready, int, S_IRUGO);
 module_param_named(unmap_alignment, sdebug_unmap_alignment, int, S_IRUGO);
 module_param_named(unmap_granularity, sdebug_unmap_granularity, int, S_IRUGO);
@@ -5812,6 +5819,8 @@ MODULE_PARM_DESC(ndelay, "response delay in nanoseconds (def=0 -> ignore)");
 MODULE_PARM_DESC(no_lun_0, "no LU number 0 (def=0 -> have lun 0)");
 MODULE_PARM_DESC(no_rwlock, "don't protect user data reads+writes (def=0)");
 MODULE_PARM_DESC(no_uld, "stop ULD (e.g. sd driver) attaching (def=0))");
+MODULE_PARM_DESC(preserves_write_order,
+		 "Whether or not to inform the block layer that this driver preserves the order of WRITE commands (def=0)");
 MODULE_PARM_DESC(num_parts, "number of partitions(def=0)");
 MODULE_PARM_DESC(num_tgts, "number of targets per host to simulate(def=1)");
 MODULE_PARM_DESC(opt_blks, "optimal transfer length in blocks (def=1024)");

  parent reply	other threads:[~2023-10-18 17:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 17:54 [PATCH v13 00/18] Improve write performance for zoned UFS devices Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 01/18] block: Introduce more member variables related to zone write locking Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 02/18] block: Only use write locking if necessary Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 03/18] block: Preserve the order of requeued zoned writes Bart Van Assche
2023-10-19  0:15   ` Damien Le Moal
2023-10-20 19:17     ` Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 04/18] block/mq-deadline: Only use zone locking if necessary Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 05/18] scsi: core: Introduce a mechanism for reordering requests in the error handler Bart Van Assche
2023-10-19  0:24   ` Damien Le Moal
2023-10-19 17:53     ` Bart Van Assche
2023-10-19 19:50       ` Bart Van Assche
2023-10-19 22:49       ` Damien Le Moal
2023-10-18 17:54 ` [PATCH v13 06/18] scsi: core: Add unit tests for scsi_call_prepare_resubmit() Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 07/18] scsi: sd: Sort commands by LBA before resubmitting Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 08/18] scsi: sd: Add a unit test for sd_cmp_sector() Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 09/18] scsi: core: Retry unaligned zoned writes Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 10/18] scsi: sd_zbc: Only require an I/O scheduler if needed Bart Van Assche
2023-10-19  0:26   ` Damien Le Moal
2023-10-19 16:54     ` Bart Van Assche
2023-10-19 22:43       ` Damien Le Moal
2023-10-18 17:54 ` Bart Van Assche [this message]
2023-10-18 17:54 ` [PATCH v13 12/18] scsi: scsi_debug: Support injecting unaligned write errors Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 13/18] scsi: ufs: hisi: Rework the code that disables auto-hibernation Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 14/18] scsi: ufs: Rename ufshcd_auto_hibern8_enable() and make it static Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 15/18] scsi: ufs: Change the return type of ufshcd_auto_hibern8_update() Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 16/18] scsi: ufs: Simplify ufshcd_auto_hibern8_update() Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 17/18] scsi: ufs: Forbid auto-hibernation without I/O scheduler Bart Van Assche
2023-10-18 17:54 ` [PATCH v13 18/18] scsi: ufs: Inform the block layer about write ordering Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231018175602.2148415-12-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=dgilbert@interlog.com \
    --cc=dlemoal@kernel.org \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox