Re: [PATCH v14 12/19] scsi: scsi_debug: Add the preserves_write_order module parameter

Bart Van Assche
2023-10-24T17:25:08Z

On 10/23/23 17:13, Damien Le Moal wrote:
> On 10/24/23 06:54, Bart Van Assche wrote:
>> static int scsi_debug_slave_alloc(struct scsi_device *sdp)
>> {
>> + struct request_queue *q = sdp->request_queue;
>> +
>> if (sdebug_verbose)
>> pr_info("slave_alloc <%u %u %u %llu>\n",
>> sdp->host->host_no, sdp->channel, sdp->id, sdp->lun);
>> + if (sdeb_preserves_write_order)
>> + q->limits.driver_preserves_write_order = true;
>
> Nit: this could simply be:
>
> q->limits.driver_preserves_write_order = sdeb_preserves_write_order;
>
>> return 0;
>> }

I will make this change.

> Otherwise, looks OK to me.
>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

Thanks for the review!

Bart.