From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] megaraid: fixup debug message in megaraid_abort_and_reset()
Date: Tue, 24 Oct 2023 08:25:33 +0200 [thread overview]
Message-ID: <20231024062533.GD8258@lst.de> (raw)
In-Reply-To: <20231023073021.21954-1-hare@suse.de>
On Mon, Oct 23, 2023 at 09:30:21AM +0200, Hannes Reinecke wrote:
> @@ -1925,10 +1925,12 @@ megaraid_abort_and_reset(adapter_t *adapter, struct scsi_cmnd *cmd, int aor)
> struct list_head *pos, *next;
> scb_t *scb;
>
> - dev_warn(&adapter->dev->dev, "%s cmd=%x <c=%d t=%d l=%d>\n",
> - (aor == SCB_ABORT)? "ABORTING":"RESET",
> - cmd->cmnd[0], cmd->device->channel,
> - cmd->device->id, (u32)cmd->device->lun);
> + if (aor == SCB_ABORT)
> + dev_warn(&adapter->dev->dev, "ABORTING cmd=%x <c=%d t=%d l=%d>\n",
Please avoid the overly long line here.
Otherwise looks good.
next prev parent reply other threads:[~2023-10-24 6:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 7:30 [PATCH] megaraid: fixup debug message in megaraid_abort_and_reset() Hannes Reinecke
2023-10-24 6:25 ` Christoph Hellwig [this message]
2023-10-25 2:41 ` Martin K. Petersen
2023-10-30 15:34 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024062533.GD8258@lst.de \
--to=hch@lst.de \
--cc=dan.carpenter@linaro.org \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox