Re: [PATCH v12 02/20] scsi: Have scsi-ml retry scsi_probe_lun errors

Mike Christie
2023-11-16T16:38:45Z

On 11/16/23 5:14 AM, John Garry wrote:
> On 14/11/2023 01:37, Mike Christie wrote:
>>         /* Each pass gets up to three chances to ignore Unit Attention */
>> +    scsi_reset_failures(&failures);
>> +
>>       for (count = 0; count < 3; ++count) {
>
> So do we keep this loop for the USB workaround (not shown)? I just wonder why we retry in this outer loop as well as now inside scsi_execute_cmd(). Maybe I'm missing something ....

The outer loop is for the inquiry len retries not shown. I didn't
know it was for usb. It's where we retry with a different inquiry len
to try and get more of the data. scsi_execute_cmd doesn't support that
type of thing where the data len change between retries so we still
have this loop.