Re: [PATCH v4 01/15] fs: Rename the kernel-internal data lifetime constants

Christoph Hellwig
2023-11-27T07:08:36Z

On Tue, Nov 14, 2023 at 01:40:56PM -0800, Bart Van Assche wrote:
> - case WRITE_LIFE_SHORT:
> + case WRITE_LIFE_2:
> return CURSEG_HOT_DATA;
> - case WRITE_LIFE_EXTREME:
> + case WRITE_LIFE_5:
> return CURSEG_COLD_DATA;
> default:
> return CURSEG_WARM_DATA;

A WRITE_LIFE_2 constant is strictly more confusing than just using 2,
so this patch makes no sense whatsoever.

More importantly these constant have been around forever, so we'd better
have a really good argument for changing them.