Re: [PATCH v1 2/4] mpi3mr: Support PCIe Error Recovery callback handlers

kernel test robot
2023-12-07T15:07:57Z

Hi Ranjan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on next-20231207]
[cannot apply to jejb-scsi/for-next linus/master v6.7-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Ranjan-Kumar/mpi3mr-Improve-Shutdown-times-when-firmware-has-faulted/20231207-004256
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link: https://lore.kernel.org/r/20231206152513.71253-3-ranjan.kumar%40broadcom.com
patch subject: [PATCH v1 2/4] mpi3mr: Support PCIe Error Recovery callback handlers
config: arc-randconfig-001-20231207 (https://download.01.org/0day-ci/archive/20231207/202312072213.uopHjdQV-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231207/202312072213.uopHjdQV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312072213.uopHjdQV-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/scsi/mpi3mr/mpi3mr_os.c:5272: warning: Function parameter or member 'mrioc' not described in 'mpi3mr_get_shost_and_mrioc'
>> drivers/scsi/mpi3mr/mpi3mr_os.c:5272: warning: Excess function parameter 'ioc' description in 'mpi3mr_get_shost_and_mrioc'

vim +5272 drivers/scsi/mpi3mr/mpi3mr_os.c

5258
5259 /**
5260 * mpi3mr_get_shost_and_mrioc - get shost and ioc reference if
5261 * they are valid
5262 * @pdev: PCI device struct
5263 * @shost: address to store scsi host reference
5264 * @ioc: address store HBA adapter reference
5265 *
5266 * Return: 0 if *shost and *ioc are not NULL otherwise -1.
5267 */
5268
5269 static int
5270 mpi3mr_get_shost_and_mrioc(struct pci_dev *pdev,
5271 struct Scsi_Host **shost, struct mpi3mr_ioc **mrioc)
> 5272 {
5273 *shost = pci_get_drvdata(pdev);
5274 if (*shost == NULL) {
5275 dev_err(&pdev->dev, "pdev's driver data is null\n");
5276 return -1;
5277 }
5278
5279 *mrioc = shost_priv(*shost);
5280 if (*mrioc == NULL) {
5281 dev_err(&pdev->dev, "shost's private data is null\n");
5282 *shost = NULL;
5283 return -1;
5284 }
5285 return 0;
5286 }
5287

--
0-DAY CI Kernel Test Service