From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JqWxNk/8" Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3BF6D44 for ; Wed, 6 Dec 2023 21:32:05 -0800 (PST) Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6ce4d4c5ea2so227836b3a.0 for ; Wed, 06 Dec 2023 21:32:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701927125; x=1702531925; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=NnvGGl844Mt88/eDFjnKsRhrcFq+x0ulAemxO2S+bfU=; b=JqWxNk/8LBdyyfAMc3QDFfDiE6mnBtHIQ1ohAfisVnnZy4nO/iuUF49OJavBGd5887 oIyYKmVqZTexFEPlsdFRhkiQ70VJnqCDTUKHARv/KbP8S4ecAMQXd8WBTGEhh1Eg0WFL ow6/qOFR9PT1TX7pRWjGwY1egeCAH5fPfKJDzMtOJAcjc8RL/SKpUClG6CLrcIZcHeb9 PEZf3TNONWu1sDy+qLFM98j7aZ1dJ6L+pif+E3+JGSENF8ll2/Etnh6tL8udKEgRc3uL QxQDaW3+5olmdHxp3pZZeULzRuCQC5wr49CT+iWMHoiEwHiyIv8nECLw9nnkY7Cnld7c MlWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701927125; x=1702531925; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NnvGGl844Mt88/eDFjnKsRhrcFq+x0ulAemxO2S+bfU=; b=TZ1jNIK3Dkh4SINumz5odSn7dNe8T5TD5Ina+0haYaOYZm4dayKppkAFi6K8zV6r3t dGPqvphoeQIRfhLFt4gE76OL9v9oDRE5A8huDlx+gty1uS/G45pVxweQo8dev7Q7zyZ0 UlmK20Ae/+c4wLLCXFO6r6rx2C8paDP7+SmWnRZVFbWhFkzZLqPzc3QW+uaXQpeGPq/M fmpHdP74hC1Cw4wZuxQ6UHBTDFgYf4895UgiyojYDfRfLNaQUZ5OkkS0qw9KgyvGT9Mp XPfBf0nqpWpu/b2peVPYq93aRWcxG54/GC29nv1ATx8RPt54pBu1vxQMx1xrJUAU1U6b 3T4A== X-Gm-Message-State: AOJu0Yw1YyfCg2CPLtOcdbWCYmCW8vXNS0aEJQct/o5YJfkGR7hxb3KD 5mmkZKhI41hQWHLXxGj+/8En X-Google-Smtp-Source: AGHT+IH6OaEgUEGq8ikcE2Z92TNqQ+21Ktn5NHM/RrKbtopBSOAZZ3yFsq/Flh5tRCPQL4wEiSO+OQ== X-Received: by 2002:a05:6a20:3d8e:b0:18d:2748:ea22 with SMTP id s14-20020a056a203d8e00b0018d2748ea22mr1917241pzi.17.1701927125136; Wed, 06 Dec 2023 21:32:05 -0800 (PST) Received: from thinkpad ([117.248.6.133]) by smtp.gmail.com with ESMTPSA id y16-20020a17090322d000b001d1c96a0c63sm378626plg.274.2023.12.06.21.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 21:32:04 -0800 (PST) Date: Thu, 7 Dec 2023 11:01:59 +0530 From: Manivannan Sadhasivam To: Andrew Halaney Cc: martin.petersen@oracle.com, jejb@linux.ibm.com, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com Subject: Re: [PATCH 11/13] scsi: ufs: qcom: Remove unused ufs_qcom_hosts struct array Message-ID: <20231207053159.GC2932@thinkpad> References: <20231201151417.65500-1-manivannan.sadhasivam@linaro.org> <20231201151417.65500-12-manivannan.sadhasivam@linaro.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Dec 06, 2023 at 12:54:43PM -0600, Andrew Halaney wrote: > On Fri, Dec 01, 2023 at 08:44:15PM +0530, Manivannan Sadhasivam wrote: > > ufs_qcom_hosts array is assigned, but not used anywhere. So let's remove > > it. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/ufs/host/ufs-qcom.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > > index a86f6620abc8..824c006be093 100644 > > --- a/drivers/ufs/host/ufs-qcom.c > > +++ b/drivers/ufs/host/ufs-qcom.c > > @@ -90,8 +90,6 @@ static const struct __ufs_qcom_bw_table { > > [MODE_MAX][0][0] = { 7643136, 307200 }, > > }; > > > > -static struct ufs_qcom_host *ufs_qcom_hosts[MAX_UFS_QCOM_HOSTS]; > > - > > I think we can get rid of MAX_UFS_QCOM_HOSTS as well with this change in > place? > Yes, thanks for spotting. - Mani > > static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host); > > static int ufs_qcom_set_core_clk_ctrl(struct ufs_hba *hba, bool is_scale_up); > > > > @@ -1192,9 +1190,6 @@ static int ufs_qcom_init(struct ufs_hba *hba) > > > > ufs_qcom_setup_clocks(hba, true, POST_CHANGE); > > > > - if (hba->dev->id < MAX_UFS_QCOM_HOSTS) > > - ufs_qcom_hosts[hba->dev->id] = host; > > - > > ufs_qcom_get_default_testbus_cfg(host); > > err = ufs_qcom_testbus_config(host); > > if (err) > > -- > > 2.25.1 > > > > > > -- மணிவண்ணன் சதாசிவம்