From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BDADD2; Mon, 11 Dec 2023 08:44:47 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id D47DA68B05; Mon, 11 Dec 2023 17:44:43 +0100 (CET) Date: Mon, 11 Dec 2023 17:44:43 +0100 From: Christoph Hellwig To: Bart Van Assche Cc: Christoph Hellwig , "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Daejun Park , Kanchan Joshi , Jaegeuk Kim , Chao Yu Subject: Re: [PATCH v5 03/17] fs/f2fs: Restore the whint_mode mount option Message-ID: <20231211164443.GA25306@lst.de> References: <20231130013322.175290-1-bvanassche@acm.org> <20231130013322.175290-4-bvanassche@acm.org> <20231207174529.GC31184@lst.de> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Dec 07, 2023 at 09:39:06AM -1000, Bart Van Assche wrote: > On 12/7/23 07:45, Christoph Hellwig wrote: >> On Wed, Nov 29, 2023 at 05:33:08PM -0800, Bart Van Assche wrote: >>> Restore support for the whint_mode mount option by reverting commit >>> 930e2607638d ("f2fs: remove obsolete whint_mode"). >> >> I know that commit sets a precedence by having a horribly short and >> uninformative commit message, but please write a proper one for this >> commit and explain why you are restoring the option. Also if anything >> changed since last year. > > Hi Christoph, > > A possible approach is that I drop this patch from this patch series and > that I let the F2FS maintainers restore write hint support in F2FS. I'm not saying you should drop it. Just that it should have a useful commit message.