Re: [PATCH] scsi: ufs: core: Let the sq_lock protect sq_tail_slot access

Bart Van Assche
2023-12-20T16:35:22Z

On 12/20/23 06:50, Manivannan Sadhasivam wrote:
> On Mon, Dec 18, 2023 at 07:32:17AM -0800, Can Guo wrote:
>> If access sq_tail_slot without the protection from the sq_lock, race
>> condition can have multiple SQEs copied to duplicate SQE slot(s), which can
>> lead to multiple incredible stability issues. Fix it by moving the *dest
>> initialization, in ufshcd_send_command(), back under protection from the
>> sq_lock.
>>
>> Fixes: 3c85f087faec ("scsi: ufs: mcq: Use pointer arithmetic in ufshcd_send_command()")
>
> Cc: stable@vger.kernel.org

Hmm ... is the "Cc: stable" tag really required if a "Fixes:" tag is present?

Bart.