From: "Michael S. Tsirkin" <mst@redhat.com>
To: Li RongQing <lirongqing@baidu.com>
Cc: jasowang@redhat.com, pbonzini@redhat.com, stefanha@redhat.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
virtualization@lists.linux.dev, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] virtio_scsi: remove duplicate check if queue is broken
Date: Tue, 16 Jan 2024 08:04:15 -0500 [thread overview]
Message-ID: <20240116080403-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240116045836.12475-1-lirongqing@baidu.com>
On Tue, Jan 16, 2024 at 12:58:36PM +0800, Li RongQing wrote:
> virtqueue_enable_cb() will call virtqueue_poll() which will check if
> queue is broken at beginning, so remove the virtqueue_is_broken() call
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/scsi/virtio_scsi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> index 9d1bdcd..e15b380 100644
> --- a/drivers/scsi/virtio_scsi.c
> +++ b/drivers/scsi/virtio_scsi.c
> @@ -182,8 +182,6 @@ static void virtscsi_vq_done(struct virtio_scsi *vscsi,
> while ((buf = virtqueue_get_buf(vq, &len)) != NULL)
> fn(vscsi, buf);
>
> - if (unlikely(virtqueue_is_broken(vq)))
> - break;
> } while (!virtqueue_enable_cb(vq));
> spin_unlock_irqrestore(&virtscsi_vq->vq_lock, flags);
> }
> --
> 2.9.4
next prev parent reply other threads:[~2024-01-16 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 4:58 [PATCH] virtio_scsi: remove duplicate check if queue is broken Li RongQing
2024-01-16 13:02 ` Stefan Hajnoczi
2024-01-16 13:04 ` Michael S. Tsirkin [this message]
2024-01-17 19:46 ` Martin K. Petersen
2024-01-24 3:00 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116080403-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=martin.petersen@oracle.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox