Re: [PATCH 21/26] block: Do not check zone type in blk_check_zone_append()

Hannes Reinecke
2024-02-04T12:37:27Z

On 2/2/24 15:30, Damien Le Moal wrote:
> Zone append operations are only allowed to target sequential write
> required zones. blk_check_zone_append() uses bio_zone_is_seq() to check
> this. However, this check is not necessary because:
> 1) For NVMe ZNS namespace devices, only sequential write required zones
> exist, making the zone type check useless.
> 2) For null_blk, the driver will fail the request anyway, thus notifying
> the user that a conventional zone was targeted.
> 3) For all other zoned devices, zone append is now emulated using zone
> write plugging, which checks that a zone append operation does not
> target a conventional zone.
>
> In preparation for the removal of zone write locking and its
> conventional zone bitmap (used by bio_zone_is_seq()), remove the
> bio_zone_is_seq() call from blk_check_zone_append().
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
> block/blk-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich