Re: [PATCH 20/26] block: Remove elevator required features

Hannes Reinecke
2024-02-04T12:36:52Z

On 2/2/24 15:30, Damien Le Moal wrote:
> The only elevator feature ever implemented is ELEVATOR_F_ZBD_SEQ_WRITE
> for signaling that a scheduler implements zone write locking to tightly
> control the dispatching order of write operations to zoned block
> devices. With the removal of zone write locking support in mq-deadline
> and the reliance of all block device drivers on the block layer zone
> write plugging to control ordering of write operations to zones, the
> elevator feature ELEVATOR_F_ZBD_SEQ_WRITE is completely unused.
> Remove it, and also remove the now unused code for filtering the
> possible schedulers for a block device based on required features.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
> block/blk-settings.c | 16 ---------------
> block/elevator.c | 46 +++++-------------------------------------
> block/elevator.h | 1 -
> include/linux/blkdev.h | 10 ---------
> 4 files changed, 5 insertions(+), 68 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich