Re: [PATCH v2 2/6] arm64: dts: qcom: msm8996: unbreak UFS HCD support

Manivannan Sadhasivam
2024-02-16T13:54:33Z

On Tue, Feb 13, 2024 at 01:22:18PM +0200, Dmitry Baryshkov wrote:
> Since the commit b4e13e1ae95e ("scsi: ufs: qcom: Add multiple frequency
> support for MAX_CORE_CLK_1US_CYCLES") the Qualcomm UFS driver uses
> core_clk_unipro values from frequency table to calculate cycles_in_1us.
> The DT file for MSM8996 passed 0 HZ frequencies there, resulting in
> broken UFS support on that platform. Fix the corresponding clock values
> in the frequency table.
>
> Suggested-by: Nitin Rawat <quic_nitirawa@quicinc.com>
> Fixes: 57fc67ef0d35 ("arm64: dts: qcom: msm8996: Add ufs related nodes")
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index f6b6fdc12f44..80d83e01bb4d 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -2077,7 +2077,7 @@ ufshc: ufshc@624000 {
> <0 0>,
> <0 0>,
> <150000000 300000000>,
> - <0 0>,
> + <75000000 150000000>,
> <0 0>,
> <0 0>,
> <0 0>,
>
> --
> 2.39.2
>

--
மணிவண்ணன் சதாசிவம்