Re: [PATCH v2 06/28] block: Remember zone capacity when revalidating zones

Bart Van Assche
2024-03-25T21:53:31Z

On 3/24/24 21:44, Damien Le Moal wrote:
> + /*
> + * Remember the capacity of the first sequential zone and check
> + * if it is constant for all zones.
> + */
> + if (!args->zone_capacity)
> + args->zone_capacity = zone->capacity;
> + if (zone->capacity != args->zone_capacity) {
> + pr_warn("%s: Invalid variable zone capacity\n",
> + disk->disk_name);
> + return -ENODEV;
> + }

The above code won't refuse devices for which the first few zones have
capacity zero. Shouldn't these be rejected?

Thanks,

Bart.