Re: [PATCH v2 06/28] block: Remember zone capacity when revalidating zones

Damien Le Moal
2024-03-25T23:20:54Z

On 3/26/24 06:53, Bart Van Assche wrote:
> On 3/24/24 21:44, Damien Le Moal wrote:
>> + /*
>> + * Remember the capacity of the first sequential zone and check
>> + * if it is constant for all zones.
>> + */
>> + if (!args->zone_capacity)
>> + args->zone_capacity = zone->capacity;
>> + if (zone->capacity != args->zone_capacity) {
>> + pr_warn("%s: Invalid variable zone capacity\n",
>> + disk->disk_name);
>> + return -ENODEV;
>> + }
>
> The above code won't refuse devices for which the first few zones have
> capacity zero. Shouldn't these be rejected?

The device driver is supposed to ensure that zone capacity is always set to the
device reported value or to the zone size for devices that do not have a zone
capacity smaller than the zone size. But sure, I can add a check.

--
Damien Le Moal
Western Digital Research