Re: [PATCH v2 03/28] block: Introduce blk_zone_update_request_bio()

Damien Le Moal
2024-03-26T07:47:38Z

On 3/26/24 15:37, Christoph Hellwig wrote:
> On Tue, Mar 26, 2024 at 08:23:19AM +0900, Damien Le Moal wrote:
>> REQ_OP_ZONE_APPEND + RQF_FLUSH_SEQ is not something supported, and this patch
>> series is not changing that. The reason is that the flush machinery is not
>> zone-append aware and will break if such request is issued for a device that
>> does not support fua. We probably should check for this, but that is not
>> something for this series to do and should be a separate fix.
>
> Btw, I don't think we're even catching this right now. Would be great
> to have a submission path check for it.

Yep, we are not checking this, but we should. Will send a separate patch for this.

--
Damien Le Moal
Western Digital Research