From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E641B74BE2; Tue, 26 Mar 2024 06:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711435160; cv=none; b=tLLplkmG0QhKfF0t9nuTFiWU/T8bOH54GY6Vzzz+BQoL1AdW91ODMwq5RvO28IKfcZb6DVydDoc/iBUaqSrW33a4GAzLSNv11RBUgyIIHTbm6LWfc7/aMw1ZgzlOrVa+5I5lbjibXAbV2+3fZhXUNMYmouk6W7u2BYHywEIPnYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711435160; c=relaxed/simple; bh=jrfmVvT3S7W+clvvumpDWCaHkWdg/2lgMSWBhMBZGXE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PEobamZteTi04qEtXR8gZYdqp8XAe5JJkdTFS0JoqoafjqEFKCZCbJlMzRscgEaST+5GNbPGqOk7tgm5hXRgWQEpyY7QGj6COBQCaGRWhe5zSu5m3iQ40D5mBu03mvlzd9UHwtAsDHtlaE4I4Qxf4BjYzOHTKGMAqtPCoFn9XXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 205A968D37; Tue, 26 Mar 2024 07:39:15 +0100 (CET) Date: Tue, 26 Mar 2024 07:39:14 +0100 From: Christoph Hellwig To: Damien Le Moal Cc: linux-block@vger.kernel.org, Jens Axboe , linux-scsi@vger.kernel.org, "Martin K . Petersen" , dm-devel@lists.linux.dev, Mike Snitzer , Christoph Hellwig Subject: Re: [PATCH v2 04/28] block: Introduce bio_straddle_zones() and bio_offset_from_zone_start() Message-ID: <20240326063914.GC7696@lst.de> References: <20240325044452.3125418-1-dlemoal@kernel.org> <20240325044452.3125418-5-dlemoal@kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240325044452.3125418-5-dlemoal@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Mar 25, 2024 at 01:44:28PM +0900, Damien Le Moal wrote: > Implement the inline helper functions bio_straddle_zones() and > bio_offset_from_zone_start() to respectively test if a BIO crosses a > zone boundary (the start sector and last sector belong to different > zones) and to obtain the offset of a BIO from the start sector of its > target zone. Looks good: Reviewed-by: Christoph Hellwig (the grammar fix from Bart looks good as well)