From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0504C1E4A2; Thu, 4 Apr 2024 13:01:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712235693; cv=none; b=dd+PqNSlBpVQL2O/I9DFg1ycK+uPDEZYA9mwMu1FsKMq+htvssuJn/15+8/k2kQA4btTYfwMMhwG0Z5R2kFvoAfoFXYXlsAMXOsXT8nEU11+mM5qrnU8UTbkLKc+Rb/SbbrxklqGY+cG0IQvWRscmpkIJjIlb46I+iz/Jym0E5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712235693; c=relaxed/simple; bh=ahPv2aISO6mwkEDr+g7AhXKh7nD0iQvZKFDvKrjlLnE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lzTaQx4w0vqGN5xez61hVHedwX/nyHJ3mx/bu/qe0bsqTH5V8X9PDKQV+Of7nhpOtR6u4iGltlldQOjfYpH1DwY2ETtWhcuezW4k2Bt+OCC5FvHbNgsH1hICogPVeHMGLo4M1jJuKYJ9HzVrIGfhYGY1slPvqLyOV+TFvJdiI2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZdKmzqsq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZdKmzqsq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43D6CC433C7; Thu, 4 Apr 2024 13:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712235692; bh=ahPv2aISO6mwkEDr+g7AhXKh7nD0iQvZKFDvKrjlLnE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZdKmzqsqsd9SZw520Qu8YgIgS0NDnyZXU3FV3KZiW/sen/MPZWNYwZEVu54qwCyEq bvmed3ixm6wbYMKfm7GX2PSBVE3kEzxZdtH7Y86qBGgvveFk03zXJft18HS9Nhq6DD Mwcm4yMvmlNVJrmiXJgGF2YHRfbHh/lgZ56aRKoY= Date: Thu, 4 Apr 2024 15:01:29 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Jens Axboe , "Martin K. Petersen" , Damien Le Moal , Niklas Cassel , Takashi Sakamoto , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "Juergen E. Fischer" , Xiang Chen , HighPoint Linux Team , Tyrel Datwyler , Brian King , Lee Duncan , Chris Leech , Mike Christie , John Garry , Jason Yan , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , Jack Wang , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, Alim Akhtar , Avri Altman , Bart Van Assche , Krzysztof Kozlowski , Alan Stern , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux1394-devel@lists.sourceforge.net, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, megaraidlinux.pdl@broadcom.com, mpi3mr-linuxdrv.pdl@broadcom.com, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net Subject: Re: [PATCH 22/23] uas: switch to using ->device_configure to configure queue limits Message-ID: <2024040422-justify-portfolio-4a66@gregkh> References: <20240402130645.653507-1-hch@lst.de> <20240402130645.653507-23-hch@lst.de> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240402130645.653507-23-hch@lst.de> On Tue, Apr 02, 2024 at 03:06:44PM +0200, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_alloc > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Note that uas was the only driver setting these size limits from > ->slave_alloc and not ->slave_configure and this makes it match > everyone else. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Damien Le Moal > --- > drivers/usb/storage/uas.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Acked-by: Greg Kroah-Hartman