From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@kernel.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Martin Wilck <martin.wilck@suse.com>
Subject: Re: [PATCH] scsi_lib: Align max_sectors to kb
Date: Thu, 18 Apr 2024 09:03:04 +0200 [thread overview]
Message-ID: <20240418070304.GA26607@lst.de> (raw)
In-Reply-To: <20240418070015.27781-1-hare@kernel.org>
On Thu, Apr 18, 2024 at 09:00:15AM +0200, Hannes Reinecke wrote:
> max_sectors can be modified via sysfs, but only in kb units.
Yes.
> Which leads to a misalignment on stacked devices if the original
> max_sector size is an odd number.
How?
Note that we really should not stack max_sectors anyway, as it's only
used for splitting in the lower device to start with.
next prev parent reply other threads:[~2024-04-18 7:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 7:00 [PATCH] scsi_lib: Align max_sectors to kb Hannes Reinecke
2024-04-18 7:03 ` Christoph Hellwig [this message]
2024-04-18 7:42 ` Hannes Reinecke
2024-04-18 9:00 ` Martin Wilck
2024-04-18 14:51 ` Christoph Hellwig
2024-04-18 16:46 ` Martin Wilck
2024-04-19 6:20 ` Christoph Hellwig
2024-04-19 8:27 ` Martin Wilck
2024-04-22 7:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418070304.GA26607@lst.de \
--to=hch@lst.de \
--cc=hare@kernel.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=martin.wilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox