From: Christoph Hellwig <hch@lst.de>
To: Martin Wilck <martin.wilck@suse.com>
Cc: Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Hannes Reinecke <hare@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_lib: Align max_sectors to kb
Date: Fri, 19 Apr 2024 08:20:35 +0200 [thread overview]
Message-ID: <20240419062035.GA12480@lst.de> (raw)
In-Reply-To: <410750a52af76fdc3bcf6265c9036037cb8141da.camel@suse.com>
On Thu, Apr 18, 2024 at 06:46:06PM +0200, Martin Wilck wrote:
> > Why would we? It makes absolutly no sense to inherit these limits,
> > the lower device will split anyway which is very much the point of
> > the immutable bio_vec work.
> >
>
> Sorry, I don't follow. With (request-based) dm-multipath on top of
> SCSI, we hit the "over max size limit" condition in
> blk_insert_cloned_request() [1], which will cause IO to fail at the dm
> level. So at least in this configuration, it's crucial that the upper
> device inherit the lower device's limits.
Oh, indeed. Request based multipath is different from everyone else.
I really wish we could spend the effort to convert it to bio based
and remove this special case..
next prev parent reply other threads:[~2024-04-19 6:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 7:00 [PATCH] scsi_lib: Align max_sectors to kb Hannes Reinecke
2024-04-18 7:03 ` Christoph Hellwig
2024-04-18 7:42 ` Hannes Reinecke
2024-04-18 9:00 ` Martin Wilck
2024-04-18 14:51 ` Christoph Hellwig
2024-04-18 16:46 ` Martin Wilck
2024-04-19 6:20 ` Christoph Hellwig [this message]
2024-04-19 8:27 ` Martin Wilck
2024-04-22 7:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419062035.GA12480@lst.de \
--to=hch@lst.de \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=martin.wilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox