From: Bui Quang Minh <minhquangbui99@gmail.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>,
Rasesh Mody <rmody@marvell.com>,
Sudarsana Kalluru <skalluru@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
Krishna Gudipati <kgudipat@brocade.com>,
Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Fabian Frederick <fabf@skynet.be>,
Saurav Kashyap <skashyap@marvell.com>,
Javed Hasan <jhasan@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
Nilesh Javali <nilesh.javali@cavium.com>,
Arun Easi <arun.easi@cavium.com>,
Manish Rangankar <manish.rangankar@cavium.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Saurav Kashyap <saurav.kashyap@cavium.com>,
linux-s390@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Bui Quang Minh <minhquangbui99@gmail.com>
Subject: [PATCH 4/5] drivers/scsi/qedf: ensure the copied buf is NULL terminated
Date: Mon, 22 Apr 2024 23:41:39 +0700 [thread overview]
Message-ID: <20240422-fix-oob-read-v1-4-e02854c30174@gmail.com> (raw)
In-Reply-To: <20240422-fix-oob-read-v1-0-e02854c30174@gmail.com>
Currently, we allocate a count-sized kernel buffer and copy count from
userspace to that buffer. Later, we use kstrtouint on this buffer but we
don't ensure that the string is terminated inside the buffer, this can
lead to OOB read when using kstrtouint. Fix this issue by using
memdup_user_nul instead of memdup_user.
Fixes: 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.")
Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
---
drivers/scsi/qedf/qedf_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qedf/qedf_debugfs.c b/drivers/scsi/qedf/qedf_debugfs.c
index 451fd236bfd0..96174353e389 100644
--- a/drivers/scsi/qedf/qedf_debugfs.c
+++ b/drivers/scsi/qedf/qedf_debugfs.c
@@ -170,7 +170,7 @@ qedf_dbg_debug_cmd_write(struct file *filp, const char __user *buffer,
if (!count || *ppos)
return 0;
- kern_buf = memdup_user(buffer, count);
+ kern_buf = memdup_user_nul(buffer, count);
if (IS_ERR(kern_buf))
return PTR_ERR(kern_buf);
--
2.34.1
next prev parent reply other threads:[~2024-04-22 16:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 16:41 [PATCH 0/5] Ensure the copied buf is NULL terminated Bui Quang Minh
2024-04-22 16:41 ` [PATCH 1/5] drivers/net/ethernet/intel-ice: ensure " Bui Quang Minh
2024-04-23 9:20 ` Przemek Kitszel
2024-04-22 16:41 ` [PATCH 2/5] drivers/net/brocade-bnad: " Bui Quang Minh
2024-04-22 16:41 ` [PATCH 3/5] drivers/scsi/bfa/bfad: " Bui Quang Minh
2024-04-22 16:41 ` Bui Quang Minh [this message]
2024-04-22 16:41 ` [PATCH 5/5] drivers/s390/cio: " Bui Quang Minh
2024-04-23 6:50 ` Heiko Carstens
2024-04-23 14:46 ` Bui Quang Minh
2024-04-24 11:55 ` Heiko Carstens
2024-04-23 11:10 ` [Intel-wired-lan] [PATCH 0/5] Ensure " Marcin Szycik
2024-04-23 11:25 ` Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422-fix-oob-read-v1-4-e02854c30174@gmail.com \
--to=minhquangbui99@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=anil.gurumurthy@qlogic.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arun.easi@cavium.com \
--cc=axboe@kernel.dk \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabf@skynet.be \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jhasan@marvell.com \
--cc=kgudipat@brocade.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manish.rangankar@cavium.com \
--cc=martin.petersen@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=nilesh.javali@cavium.com \
--cc=oberpar@linux.ibm.com \
--cc=pabeni@redhat.com \
--cc=paul.m.stillwell.jr@intel.com \
--cc=rmody@marvell.com \
--cc=saurav.kashyap@cavium.com \
--cc=skalluru@marvell.com \
--cc=skashyap@marvell.com \
--cc=sudarsana.kalluru@qlogic.com \
--cc=svens@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox