Re: [PATCH] scsi: qla2xxx: Fix double free of fcport in error handling path

Markus Elfring
2024-04-25T11:31:36Z

…
> Fix this by cleaning up the redundant qla2x00_free_fcport().
…

I suggest to avoid duplicate error handling code a bit more
also for the implementation of the function “qla24xx_els_dcmd_iocb”.
https://elixir.bootlin.com/linux/v6.9-rc5/source/drivers/scsi/qla2xxx/qla_iocb.c#L2751

See also:
https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources

Regards,
Markus