Re: [PATCH v1 1/6] mpi3mr: HDB allocation and posting for hardware and Firmware buffers

kernel test robot
2024-05-15T09:59:40Z

Hi Ranjan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on jejb-scsi/for-next linus/master v6.9 next-20240515]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Ranjan-Kumar/mpi3mr-HDB-allocation-and-posting-for-hardware-and-Firmware-buffers/20240514-223346
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link: https://lore.kernel.org/r/20240514142858.51992-2-ranjan.kumar%40broadcom.com
patch subject: [PATCH v1 1/6] mpi3mr: HDB allocation and posting for hardware and Firmware buffers
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240515/202405151758.7xrJz6rp-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240515/202405151758.7xrJz6rp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405151758.7xrJz6rp-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/scsi/mpi3mr/mpi3mr_app.c:460: warning: Function parameter or struct member 'trigger_data' not described in 'mpi3mr_set_trigger_data_in_hdb'
>> drivers/scsi/mpi3mr/mpi3mr_app.c:460: warning: Excess function parameter 'data' description in 'mpi3mr_set_trigger_data_in_hdb'

vim +460 drivers/scsi/mpi3mr/mpi3mr_app.c

443
444 /**
445 * mpi3mr_set_trigger_data_in_hdb - Updates HDB trigger type and
446 * trigger data
447 *
448 * @hdb: HDB pointer
449 * @type: Trigger type
450 * @data: Trigger data
451 * @force: Trigger overwrite flag
452 *
453 * Updates trigger type and trigger data based on parameter
454 * passed to this function
455 *
456 * Return: Nothing
457 */
458 void mpi3mr_set_trigger_data_in_hdb(struct diag_buffer_desc *hdb,
459 u8 type, union mpi3mr_trigger_data *trigger_data, bool force)
> 460 {
461 if ((!force) && (hdb->trigger_type != MPI3MR_HDB_TRIGGER_TYPE_UNKNOWN))
462 return;
463 hdb->trigger_type = type;
464 if (!trigger_data)
465 memset(&hdb->trigger_data, 0, sizeof(*trigger_data));
466 else
467 memcpy(&hdb->trigger_data, trigger_data, sizeof(*trigger_data));
468 }
469

--
0-DAY CI Kernel Test Service