* [PATCH v2] scsi: core: Fix an incorrect comment
@ 2024-06-12 17:15 Bart Van Assche
2024-06-14 0:55 ` Martin K. Petersen
2024-06-27 3:37 ` Martin K. Petersen
0 siblings, 2 replies; 5+ messages in thread
From: Bart Van Assche @ 2024-06-12 17:15 UTC (permalink / raw)
To: Martin K . Petersen
Cc: linux-scsi, Bart Van Assche, Christoph Hellwig, Avri Altman,
James E.J. Bottomley
The comment that scsi_static_device_list would go away was added more
than 18 years ago. Today, that list is still there and a large number
of additional entries have been added. This shows that this comment is
incorrect. Hence fix that comment.
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Avri Altman <Avri.Altman@wdc.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
Changes compared to v1: addressed Christoph's review feedback.
drivers/scsi/scsi_devinfo.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index a7071e71389e..90f1393a23f8 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -39,13 +39,12 @@ static LIST_HEAD(scsi_dev_info_list);
static char scsi_dev_flags[256];
/*
- * scsi_static_device_list: deprecated list of devices that require
- * settings that differ from the default, includes black-listed (broken)
- * devices. The entries here are added to the tail of scsi_dev_info_list
- * via scsi_dev_info_list_init.
+ * scsi_static_device_list: list of devices that require settings that differ
+ * from the default, includes black-listed (broken) devices. The entries here
+ * are added to the tail of scsi_dev_info_list via scsi_dev_info_list_init.
*
- * Do not add to this list, use the command line or proc interface to add
- * to the scsi_dev_info_list. This table will eventually go away.
+ * If possible, set the BLIST_* flags from inside a SCSI LLD rather than
+ * adding an entry to this list.
*/
static struct {
char *vendor;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] scsi: core: Fix an incorrect comment
2024-06-12 20:37 [PATCH v2 0/2] Do not read the IO hints VPD page from USB storage devices Bart Van Assche
@ 2024-06-12 20:37 ` Bart Van Assche
2024-06-12 21:41 ` Bart Van Assche
0 siblings, 1 reply; 5+ messages in thread
From: Bart Van Assche @ 2024-06-12 20:37 UTC (permalink / raw)
To: Martin K . Petersen
Cc: Alan Stern, linux-scsi, linux-usb, Bart Van Assche,
Christoph Hellwig, Avri Altman, James E.J. Bottomley
The comment that scsi_static_device_list would go away was added more
than 18 years ago. Today, that list is still there and a large number
of additional entries have been added. This shows that this comment is
incorrect. Hence fix that comment.
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Avri Altman <Avri.Altman@wdc.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
Changes compared to v1: addressed Christoph's review feedback.
drivers/scsi/scsi_devinfo.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index a7071e71389e..90f1393a23f8 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -39,13 +39,12 @@ static LIST_HEAD(scsi_dev_info_list);
static char scsi_dev_flags[256];
/*
- * scsi_static_device_list: deprecated list of devices that require
- * settings that differ from the default, includes black-listed (broken)
- * devices. The entries here are added to the tail of scsi_dev_info_list
- * via scsi_dev_info_list_init.
+ * scsi_static_device_list: list of devices that require settings that differ
+ * from the default, includes black-listed (broken) devices. The entries here
+ * are added to the tail of scsi_dev_info_list via scsi_dev_info_list_init.
*
- * Do not add to this list, use the command line or proc interface to add
- * to the scsi_dev_info_list. This table will eventually go away.
+ * If possible, set the BLIST_* flags from inside a SCSI LLD rather than
+ * adding an entry to this list.
*/
static struct {
char *vendor;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] scsi: core: Fix an incorrect comment
2024-06-12 20:37 ` [PATCH v2] scsi: core: Fix an incorrect comment Bart Van Assche
@ 2024-06-12 21:41 ` Bart Van Assche
0 siblings, 0 replies; 5+ messages in thread
From: Bart Van Assche @ 2024-06-12 21:41 UTC (permalink / raw)
To: Martin K . Petersen
Cc: Alan Stern, linux-scsi, linux-usb, Christoph Hellwig, Avri Altman,
James E.J. Bottomley
On 6/12/24 1:37 PM, Bart Van Assche wrote:
> The comment that scsi_static_device_list would go away was added more
> than 18 years ago. Today, that list is still there and a large number
> of additional entries have been added. This shows that this comment is
> incorrect. Hence fix that comment.
Please ignore this patch - this patch was already posted earlier today.
Thanks,
Bart.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] scsi: core: Fix an incorrect comment
2024-06-12 17:15 [PATCH v2] scsi: core: Fix an incorrect comment Bart Van Assche
@ 2024-06-14 0:55 ` Martin K. Petersen
2024-06-27 3:37 ` Martin K. Petersen
1 sibling, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2024-06-14 0:55 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, linux-scsi, Christoph Hellwig, Avri Altman,
James E.J. Bottomley
Bart,
> The comment that scsi_static_device_list would go away was added more
> than 18 years ago. Today, that list is still there and a large number
> of additional entries have been added. This shows that this comment is
> incorrect. Hence fix that comment.
Applied to 6.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] scsi: core: Fix an incorrect comment
2024-06-12 17:15 [PATCH v2] scsi: core: Fix an incorrect comment Bart Van Assche
2024-06-14 0:55 ` Martin K. Petersen
@ 2024-06-27 3:37 ` Martin K. Petersen
1 sibling, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2024-06-27 3:37 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, linux-scsi, Christoph Hellwig, Avri Altman,
James E.J. Bottomley
On Wed, 12 Jun 2024 10:15:21 -0700, Bart Van Assche wrote:
> The comment that scsi_static_device_list would go away was added more
> than 18 years ago. Today, that list is still there and a large number
> of additional entries have been added. This shows that this comment is
> incorrect. Hence fix that comment.
>
>
Applied to 6.11/scsi-queue, thanks!
[1/1] scsi: core: Fix an incorrect comment
https://git.kernel.org/mkp/scsi/c/14d38356ec33
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-06-27 3:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-12 17:15 [PATCH v2] scsi: core: Fix an incorrect comment Bart Van Assche
2024-06-14 0:55 ` Martin K. Petersen
2024-06-27 3:37 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2024-06-12 20:37 [PATCH v2 0/2] Do not read the IO hints VPD page from USB storage devices Bart Van Assche
2024-06-12 20:37 ` [PATCH v2] scsi: core: Fix an incorrect comment Bart Van Assche
2024-06-12 21:41 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).