Re: [PATCH 3/8] scsi: ufs: Inline ufshcd_mcq_vops_get_hba_mac()

Bart Van Assche
2024-06-18T16:14:41Z

On 6/17/24 11:23 PM, Avri Altman wrote:
>
>> Make ufshcd_mcq_decide_queue_depth() easier to read by inlining
>> ufshcd_mcq_vops_get_hba_mac().
>
> This changes its functionality by making it non-mandatory.
> Maybe relate to that in the commit log.

I do not agree. Even with this patch applied, .get_hba_mac() is still
mandatory.

> Also, it would make sense to squash it to the next patch, so your line of reasoning is clear.

I prefer to keep the inlining (no functional change) separate from the
patch that introduces a behavior change.

Thanks,

Bart.