Re: [PATCH 8/8] scsi: ufs: Check for completion from the timeout handler

Peter Wang (王信友)
2024-06-26T03:54:26Z

On Tue, 2024-06-25 at 09:33 -0700, Bart Van Assche wrote:
>
>
> While ufshcd_eh_timed_out() does not set the SCMD_STATE_COMPLETE bit,
> its caller may set that bit after ufshcd_eh_timed_out() has returned.
> Hence, a command may be completed while ufshcd_eh_timed_out() is in
> progress.
>
> Thanks,
>
> Bart.

Hi Bart,

So, when this concurrency issue happen, which one set the
SCMD_STATE_COMPLETE flag?
scsi_timeout or scsi_done_internal?
And why ufshcd_queuecommand got null pointer? which pointer is null?

Thanks.
Peter