From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Ming Lei <ming.lei@redhat.com>,
"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
Jack Wang <jinpu.wang@ionos.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
Chandrakanth patil <chandrakanth.patil@broadcom.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
linux-block@vger.kernel.org, megaraidlinux.pdl@broadcom.com,
linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com
Subject: Re: get drivers out of setting queue flags
Date: Fri, 28 Jun 2024 14:30:19 +0200 [thread overview]
Message-ID: <20240628123019.GA17080@lst.de> (raw)
In-Reply-To: <e93e3171-3b30-4af1-80d8-acb9ff4900a2@oracle.com>
On Fri, Jun 28, 2024 at 08:46:08AM +0100, John Garry wrote:
> On 27/06/2024 13:49, Christoph Hellwig wrote:
>> Hi all,
>>
>> now that driver features have been moved out of the queue flags,
>> the abuses where drivers set random internal queue flags stand out
>> even more. This series fixes them up.
>
> If no driver needs to know about these flags, could they now live in
> block/*.h ?
That is my ultimate plan, but currently they still are checked in
a few places in drivers. I'll need some more time to sort this
out properly, but I hope that we'll get there.
next prev parent reply other threads:[~2024-06-28 12:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 12:49 get drivers out of setting queue flags Christoph Hellwig
2024-06-27 12:49 ` [PATCH 1/5] loop: don't set QUEUE_FLAG_NOMERGES Christoph Hellwig
2024-06-27 12:49 ` [PATCH 2/5] megaraid_sas: " Christoph Hellwig
2024-06-27 12:49 ` [PATCH 3/5] mpt3sas_scsih: " Christoph Hellwig
2024-06-27 12:49 ` [PATCH 4/5] rnbd: don't set QUEUE_FLAG_SAME_COMP Christoph Hellwig
2024-06-27 12:54 ` Jinpu Wang
2024-06-27 12:49 ` [PATCH 5/5] rnbd-cnt: don't set QUEUE_FLAG_SAME_FORCE Christoph Hellwig
2024-06-27 12:58 ` Jinpu Wang
2024-06-27 14:40 ` get drivers out of setting queue flags Bart Van Assche
2024-06-28 7:46 ` John Garry
2024-06-28 12:30 ` Christoph Hellwig [this message]
2024-06-28 16:37 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240628123019.GA17080@lst.de \
--to=hch@lst.de \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=axboe@kernel.dk \
--cc=chandrakanth.patil@broadcom.com \
--cc=haris.iqbal@ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=john.g.garry@oracle.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=ming.lei@redhat.com \
--cc=sathya.prakash@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox