From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Peter Wang <peter.wang@mediatek.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Avri Altman <avri.altman@wdc.com>,
Andrew Halaney <ahalaney@redhat.com>,
Bean Huo <beanhuo@micron.com>,
ChanWoo Lee <cw9316.lee@samsung.com>
Subject: Re: [PATCH v4 4/9] scsi: ufs: Rename the MASK_TRANSFER_REQUESTS_SLOTS constant
Date: Wed, 3 Jul 2024 18:29:43 +0530 [thread overview]
Message-ID: <20240703125943.GA3498@thinkpad> (raw)
In-Reply-To: <20240702204020.2489324-5-bvanassche@acm.org>
On Tue, Jul 02, 2024 at 01:39:12PM -0700, Bart Van Assche wrote:
> Rename this constant to prepare for the introduction of the
> MASK_TRANSFER_REQUESTS_SLOTS_MCQ constant. The acronym "SDB" stands for
> "single doorbell" (mode).
>
> Reviewed-by: Peter Wang <peter.wang@mediatek.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/ufs/core/ufshcd.c | 2 +-
> include/ufs/ufshci.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 9a0697556953..2cbd0f91953b 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -2401,7 +2401,7 @@ static inline int ufshcd_hba_capabilities(struct ufs_hba *hba)
> hba->capabilities &= ~MASK_64_ADDRESSING_SUPPORT;
>
> /* nutrs and nutmrs are 0 based values */
> - hba->nutrs = (hba->capabilities & MASK_TRANSFER_REQUESTS_SLOTS) + 1;
> + hba->nutrs = (hba->capabilities & MASK_TRANSFER_REQUESTS_SLOTS_SDB) + 1;
> hba->nutmrs =
> ((hba->capabilities & MASK_TASK_MANAGEMENT_REQUEST_SLOTS) >> 16) + 1;
> hba->reserved_slot = hba->nutrs - 1;
> diff --git a/include/ufs/ufshci.h b/include/ufs/ufshci.h
> index c50f92bf2e1d..8d0cc73537c6 100644
> --- a/include/ufs/ufshci.h
> +++ b/include/ufs/ufshci.h
> @@ -67,7 +67,7 @@ enum {
>
> /* Controller capability masks */
> enum {
> - MASK_TRANSFER_REQUESTS_SLOTS = 0x0000001F,
> + MASK_TRANSFER_REQUESTS_SLOTS_SDB = 0x0000001F,
> MASK_NUMBER_OUTSTANDING_RTT = 0x0000FF00,
> MASK_TASK_MANAGEMENT_REQUEST_SLOTS = 0x00070000,
> MASK_EHSLUTRD_SUPPORTED = 0x00400000,
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-07-03 12:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 20:39 [PATCH v4 0/9] UFS patches for kernel 6.11 Bart Van Assche
2024-07-02 20:39 ` [PATCH v4 1/9] scsi: ufs: Declare functions once Bart Van Assche
2024-07-02 20:39 ` [PATCH v4 2/9] scsi: ufs: Initialize struct uic_command once Bart Van Assche
2024-07-02 20:39 ` [PATCH v4 3/9] scsi: ufs: Remove two constants Bart Van Assche
2024-07-02 20:39 ` [PATCH v4 4/9] scsi: ufs: Rename the MASK_TRANSFER_REQUESTS_SLOTS constant Bart Van Assche
2024-07-03 12:59 ` Manivannan Sadhasivam [this message]
2024-07-02 20:39 ` [PATCH v4 5/9] scsi: ufs: Initialize hba->reserved_slot earlier Bart Van Assche
2024-07-03 13:01 ` Manivannan Sadhasivam
2024-07-02 20:39 ` [PATCH v4 6/9] scsi: ufs: Inline is_mcq_enabled() Bart Van Assche
2024-07-03 8:58 ` Peter Wang (王信友)
2024-07-03 13:03 ` Manivannan Sadhasivam
2024-07-02 20:39 ` [PATCH v4 7/9] scsi: ufs: Move the ufshcd_mcq_enable() call Bart Van Assche
2024-07-03 8:59 ` Peter Wang (王信友)
2024-07-03 13:10 ` Manivannan Sadhasivam
2024-07-03 20:32 ` Bart Van Assche
2024-07-02 20:39 ` [PATCH v4 8/9] scsi: ufs: Inline ufshcd_mcq_vops_get_hba_mac() Bart Van Assche
2024-07-02 20:39 ` [PATCH v4 9/9] scsi: ufs: Make .get_hba_mac() optional Bart Van Assche
2024-07-03 9:00 ` Peter Wang (王信友)
2024-07-03 13:22 ` Manivannan Sadhasivam
2024-07-03 20:36 ` Bart Van Assche
2024-07-06 16:33 ` Manivannan Sadhasivam
2024-07-07 3:24 ` Bart Van Assche
2024-07-08 10:44 ` Manivannan Sadhasivam
2024-07-08 17:10 ` Bart Van Assche
2024-07-08 18:06 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703125943.GA3498@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ahalaney@redhat.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cw9316.lee@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox