Re: [PATCH] USB: core: add 'shutdown' callback to usb_driver

Aditya Garg
2024-07-06T08:56:10Z

Hi Greg

> On 6 Jul 2024, at 1:43 PM, gregkh@linuxfoundation.org wrote:
>
> On Fri, Jul 05, 2024 at 11:21:06AM +0000, Aditya Garg wrote:
>> From: Kerem Karabay <kekrby@gmail.com>
>>
>> This simplifies running code on shutdown for USB drivers.
>>
>
> Sorry, but this does not explain why this is needed at all :(
>
> Where did this change come from? What problem does it solve? Why
> should we take it?
>

Currently there is no standardized method for USB drivers to handle
shutdown events. This patch simplifies running code on shutdown for USB
devices by adding a shutdown callback to usb_driver. It also implements the
new method to existing "USB Attached SCSI” driver that required shutdown

Is this good enough?
> I think I know the answers to these questions, but you need to document
> it here as to why it is needed (please read the kernel documentation for
> how to write a good changelog text and subject line.)

The subject looks fine to me. If you think it can be improved, suggestions shall be appreciated.

Thanks
Aditya