public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, peter.wang@mediatek.com,
	manivannan.sadhasivam@linaro.org,
	Bart Van Assche <bvanassche@acm.org>,
	Keoseong Park <keosung.park@samsung.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Avri Altman <avri.altman@wdc.com>, Bean Huo <beanhuo@micron.com>
Subject: [PATCH v5 03/10] scsi: ufs: Remove two constants
Date: Mon,  8 Jul 2024 14:15:58 -0700	[thread overview]
Message-ID: <20240708211716.2827751-4-bvanassche@acm.org> (raw)
In-Reply-To: <20240708211716.2827751-1-bvanassche@acm.org>

The SCSI host template members .cmd_per_lun and .can_queue are copied
into the SCSI host data structure. Before these are used, these are
overwritten by ufshcd_init(). Hence, this patch does not change any
functionality.

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Keoseong Park <keosung.park@samsung.com>
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/ufs/core/ufshcd.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 13c57bbcdad7..1b0445bb5b7a 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -164,8 +164,6 @@ EXPORT_SYMBOL_GPL(ufshcd_dump_regs);
 enum {
 	UFSHCD_MAX_CHANNEL	= 0,
 	UFSHCD_MAX_ID		= 1,
-	UFSHCD_CMD_PER_LUN	= 32 - UFSHCD_NUM_RESERVED,
-	UFSHCD_CAN_QUEUE	= 32 - UFSHCD_NUM_RESERVED,
 };
 
 static const char *const ufshcd_state_name[] = {
@@ -8959,8 +8957,6 @@ static const struct scsi_host_template ufshcd_driver_template = {
 	.eh_timed_out		= ufshcd_eh_timed_out,
 	.this_id		= -1,
 	.sg_tablesize		= SG_ALL,
-	.cmd_per_lun		= UFSHCD_CMD_PER_LUN,
-	.can_queue		= UFSHCD_CAN_QUEUE,
 	.max_segment_size	= PRDT_DATA_BYTE_COUNT_MAX,
 	.max_sectors		= SZ_1M / SECTOR_SIZE,
 	.max_host_blocked	= 1,

  parent reply	other threads:[~2024-07-08 21:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 21:15 [PATCH v5 00/10] UFS patches for kernel 6.11 Bart Van Assche
2024-07-08 21:15 ` [PATCH v5 01/10] scsi: ufs: Declare functions once Bart Van Assche
2024-07-09  5:02   ` Manivannan Sadhasivam
2024-07-08 21:15 ` [PATCH v5 02/10] scsi: ufs: Initialize struct uic_command once Bart Van Assche
2024-07-08 21:15 ` Bart Van Assche [this message]
2024-07-08 21:15 ` [PATCH v5 04/10] scsi: ufs: Rename the MASK_TRANSFER_REQUESTS_SLOTS constant Bart Van Assche
2024-07-08 21:16 ` [PATCH v5 05/10] scsi: ufs: Initialize hba->reserved_slot earlier Bart Van Assche
2024-07-08 21:16 ` [PATCH v5 06/10] scsi: ufs: Inline is_mcq_enabled() Bart Van Assche
2024-07-09  5:06   ` Manivannan Sadhasivam
2024-07-15 12:22   ` Peter Wang (王信友)
2024-07-08 21:16 ` [PATCH v5 07/10] scsi: ufs: Move the "hba->mcq_enabled = true" assignment Bart Van Assche
2024-07-09  5:07   ` Manivannan Sadhasivam
2024-07-15 12:32   ` Peter Wang (王信友)
2024-07-08 21:16 ` [PATCH v5 08/10] scsi: ufs: Move the ufshcd_mcq_enable() call Bart Van Assche
2024-07-09  5:08   ` Manivannan Sadhasivam
2024-07-15 12:33   ` Peter Wang (王信友)
2024-07-08 21:16 ` [PATCH v5 09/10] scsi: ufs: Inline ufshcd_mcq_vops_get_hba_mac() Bart Van Assche
2024-07-09  5:09   ` Manivannan Sadhasivam
2024-07-08 21:16 ` [PATCH v5 10/10] scsi: ufs: Make .get_hba_mac() optional Bart Van Assche
2024-07-09  5:10   ` Manivannan Sadhasivam
2024-07-11  2:28 ` [PATCH v5 00/10] UFS patches for kernel 6.11 Martin K. Petersen
2024-07-16  2:29 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240708211716.2827751-4-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=keosung.park@samsung.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=peter.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox