From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, peter.wang@mediatek.com,
manivannan.sadhasivam@linaro.org,
Bart Van Assche <bvanassche@acm.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Minwoo Im <minwoo.im@samsung.com>,
ChanWoo Lee <cw9316.lee@samsung.com>,
Rohit Ner <rohitner@google.com>,
Naomi Chu <naomi.chu@mediatek.com>,
Yang Li <yang.lee@linux.alibaba.com>,
Avri Altman <avri.altman@wdc.com>, Bean Huo <beanhuo@micron.com>
Subject: [PATCH v5 07/10] scsi: ufs: Move the "hba->mcq_enabled = true" assignment
Date: Mon, 8 Jul 2024 14:16:02 -0700 [thread overview]
Message-ID: <20240708211716.2827751-8-bvanassche@acm.org> (raw)
In-Reply-To: <20240708211716.2827751-1-bvanassche@acm.org>
Move the "hba->mcq_enabled = true" assignment to prevent that it gets
duplicated by a later patch that will introduce more ufshcd_mcq_enable() calls.
No functionality is changed by this patch.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/ufs/core/ufs-mcq.c | 1 +
drivers/ufs/core/ufshcd.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
index 4bcae410c268..0a9597a6d059 100644
--- a/drivers/ufs/core/ufs-mcq.c
+++ b/drivers/ufs/core/ufs-mcq.c
@@ -416,6 +416,7 @@ EXPORT_SYMBOL_GPL(ufshcd_mcq_enable_esi);
void ufshcd_mcq_enable(struct ufs_hba *hba)
{
ufshcd_rmwl(hba, MCQ_MODE_SELECT, MCQ_MODE_SELECT, REG_UFS_MEM_CFG);
+ hba->mcq_enabled = true;
}
EXPORT_SYMBOL_GPL(ufshcd_mcq_enable);
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 255d55e15b73..7647d8969001 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -8704,7 +8704,6 @@ static void ufshcd_config_mcq(struct ufs_hba *hba)
ufshcd_mcq_config_mac(hba, hba->nutrs);
ufshcd_mcq_enable(hba);
- hba->mcq_enabled = true;
dev_info(hba->dev, "MCQ configured, nr_queues=%d, io_queues=%d, read_queue=%d, poll_queues=%d, queue_depth=%d\n",
hba->nr_hw_queues, hba->nr_queues[HCTX_TYPE_DEFAULT],
next prev parent reply other threads:[~2024-07-08 21:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 21:15 [PATCH v5 00/10] UFS patches for kernel 6.11 Bart Van Assche
2024-07-08 21:15 ` [PATCH v5 01/10] scsi: ufs: Declare functions once Bart Van Assche
2024-07-09 5:02 ` Manivannan Sadhasivam
2024-07-08 21:15 ` [PATCH v5 02/10] scsi: ufs: Initialize struct uic_command once Bart Van Assche
2024-07-08 21:15 ` [PATCH v5 03/10] scsi: ufs: Remove two constants Bart Van Assche
2024-07-08 21:15 ` [PATCH v5 04/10] scsi: ufs: Rename the MASK_TRANSFER_REQUESTS_SLOTS constant Bart Van Assche
2024-07-08 21:16 ` [PATCH v5 05/10] scsi: ufs: Initialize hba->reserved_slot earlier Bart Van Assche
2024-07-08 21:16 ` [PATCH v5 06/10] scsi: ufs: Inline is_mcq_enabled() Bart Van Assche
2024-07-09 5:06 ` Manivannan Sadhasivam
2024-07-15 12:22 ` Peter Wang (王信友)
2024-07-08 21:16 ` Bart Van Assche [this message]
2024-07-09 5:07 ` [PATCH v5 07/10] scsi: ufs: Move the "hba->mcq_enabled = true" assignment Manivannan Sadhasivam
2024-07-15 12:32 ` Peter Wang (王信友)
2024-07-08 21:16 ` [PATCH v5 08/10] scsi: ufs: Move the ufshcd_mcq_enable() call Bart Van Assche
2024-07-09 5:08 ` Manivannan Sadhasivam
2024-07-15 12:33 ` Peter Wang (王信友)
2024-07-08 21:16 ` [PATCH v5 09/10] scsi: ufs: Inline ufshcd_mcq_vops_get_hba_mac() Bart Van Assche
2024-07-09 5:09 ` Manivannan Sadhasivam
2024-07-08 21:16 ` [PATCH v5 10/10] scsi: ufs: Make .get_hba_mac() optional Bart Van Assche
2024-07-09 5:10 ` Manivannan Sadhasivam
2024-07-11 2:28 ` [PATCH v5 00/10] UFS patches for kernel 6.11 Martin K. Petersen
2024-07-16 2:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708211716.2827751-8-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cw9316.lee@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=minwoo.im@samsung.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=rohitner@google.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox