From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, peter.wang@mediatek.com,
manivannan.sadhasivam@linaro.org,
Bart Van Assche <bvanassche@acm.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Avri Altman <avri.altman@wdc.com>,
Andrew Halaney <ahalaney@redhat.com>,
Bean Huo <beanhuo@micron.com>
Subject: [PATCH v5 08/10] scsi: ufs: Move the ufshcd_mcq_enable() call
Date: Mon, 8 Jul 2024 14:16:03 -0700 [thread overview]
Message-ID: <20240708211716.2827751-9-bvanassche@acm.org> (raw)
In-Reply-To: <20240708211716.2827751-1-bvanassche@acm.org>
Move the ufshcd_mcq_enable() call from inside ufshcd_config_mcq() to the
callers of this function. No functionality is changed by this patch. This
patch makes a later patch easier to read ("scsi: ufs: Make .get_hba_mac()
optional").
Cc: Peter Wang <peter.wang@mediatek.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/ufs/core/ufshcd.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 7647d8969001..4c2b60dec43f 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -8703,8 +8703,6 @@ static void ufshcd_config_mcq(struct ufs_hba *hba)
ufshcd_mcq_make_queues_operational(hba);
ufshcd_mcq_config_mac(hba, hba->nutrs);
- ufshcd_mcq_enable(hba);
-
dev_info(hba->dev, "MCQ configured, nr_queues=%d, io_queues=%d, read_queue=%d, poll_queues=%d, queue_depth=%d\n",
hba->nr_hw_queues, hba->nr_queues[HCTX_TYPE_DEFAULT],
hba->nr_queues[HCTX_TYPE_READ], hba->nr_queues[HCTX_TYPE_POLL],
@@ -8732,8 +8730,10 @@ static int ufshcd_device_init(struct ufs_hba *hba, bool init_dev_params)
ufshcd_set_link_active(hba);
/* Reconfigure MCQ upon reset */
- if (hba->mcq_enabled && !init_dev_params)
+ if (hba->mcq_enabled && !init_dev_params) {
ufshcd_config_mcq(hba);
+ ufshcd_mcq_enable(hba);
+ }
/* Verify device initialization by sending NOP OUT UPIU */
ret = ufshcd_verify_dev_init(hba);
@@ -8757,6 +8757,7 @@ static int ufshcd_device_init(struct ufs_hba *hba, bool init_dev_params)
ret = ufshcd_alloc_mcq(hba);
if (!ret) {
ufshcd_config_mcq(hba);
+ ufshcd_mcq_enable(hba);
} else {
/* Continue with SDB mode */
use_mcq_mode = false;
@@ -8772,6 +8773,7 @@ static int ufshcd_device_init(struct ufs_hba *hba, bool init_dev_params)
} else if (is_mcq_supported(hba)) {
/* UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH is set */
ufshcd_config_mcq(hba);
+ ufshcd_mcq_enable(hba);
}
}
next prev parent reply other threads:[~2024-07-08 21:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 21:15 [PATCH v5 00/10] UFS patches for kernel 6.11 Bart Van Assche
2024-07-08 21:15 ` [PATCH v5 01/10] scsi: ufs: Declare functions once Bart Van Assche
2024-07-09 5:02 ` Manivannan Sadhasivam
2024-07-08 21:15 ` [PATCH v5 02/10] scsi: ufs: Initialize struct uic_command once Bart Van Assche
2024-07-08 21:15 ` [PATCH v5 03/10] scsi: ufs: Remove two constants Bart Van Assche
2024-07-08 21:15 ` [PATCH v5 04/10] scsi: ufs: Rename the MASK_TRANSFER_REQUESTS_SLOTS constant Bart Van Assche
2024-07-08 21:16 ` [PATCH v5 05/10] scsi: ufs: Initialize hba->reserved_slot earlier Bart Van Assche
2024-07-08 21:16 ` [PATCH v5 06/10] scsi: ufs: Inline is_mcq_enabled() Bart Van Assche
2024-07-09 5:06 ` Manivannan Sadhasivam
2024-07-15 12:22 ` Peter Wang (王信友)
2024-07-08 21:16 ` [PATCH v5 07/10] scsi: ufs: Move the "hba->mcq_enabled = true" assignment Bart Van Assche
2024-07-09 5:07 ` Manivannan Sadhasivam
2024-07-15 12:32 ` Peter Wang (王信友)
2024-07-08 21:16 ` Bart Van Assche [this message]
2024-07-09 5:08 ` [PATCH v5 08/10] scsi: ufs: Move the ufshcd_mcq_enable() call Manivannan Sadhasivam
2024-07-15 12:33 ` Peter Wang (王信友)
2024-07-08 21:16 ` [PATCH v5 09/10] scsi: ufs: Inline ufshcd_mcq_vops_get_hba_mac() Bart Van Assche
2024-07-09 5:09 ` Manivannan Sadhasivam
2024-07-08 21:16 ` [PATCH v5 10/10] scsi: ufs: Make .get_hba_mac() optional Bart Van Assche
2024-07-09 5:10 ` Manivannan Sadhasivam
2024-07-11 2:28 ` [PATCH v5 00/10] UFS patches for kernel 6.11 Martin K. Petersen
2024-07-16 2:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708211716.2827751-9-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ahalaney@redhat.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox