Re: [PATCH v5 07/10] scsi: ufs: Move the "hba->mcq_enabled = true" assignment

[Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>]

On Mon, Jul 08, 2024 at 02:16:02PM -0700, Bart Van Assche wrote:
> Move the "hba->mcq_enabled = true" assignment to prevent that it gets
> duplicated by a later patch that will introduce more ufshcd_mcq_enable() calls.
> No functionality is changed by this patch.
> 
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> ---
>  drivers/ufs/core/ufs-mcq.c | 1 +
>  drivers/ufs/core/ufshcd.c  | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index 4bcae410c268..0a9597a6d059 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -416,6 +416,7 @@ EXPORT_SYMBOL_GPL(ufshcd_mcq_enable_esi);
>  void ufshcd_mcq_enable(struct ufs_hba *hba)
>  {
>  	ufshcd_rmwl(hba, MCQ_MODE_SELECT, MCQ_MODE_SELECT, REG_UFS_MEM_CFG);
> +	hba->mcq_enabled = true;
>  }
>  EXPORT_SYMBOL_GPL(ufshcd_mcq_enable);
>  
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 255d55e15b73..7647d8969001 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -8704,7 +8704,6 @@ static void ufshcd_config_mcq(struct ufs_hba *hba)
>  	ufshcd_mcq_config_mac(hba, hba->nutrs);
>  
>  	ufshcd_mcq_enable(hba);
> -	hba->mcq_enabled = true;
>  
>  	dev_info(hba->dev, "MCQ configured, nr_queues=%d, io_queues=%d, read_queue=%d, poll_queues=%d, queue_depth=%d\n",
>  		 hba->nr_hw_queues, hba->nr_queues[HCTX_TYPE_DEFAULT],

-- 
மணிவண்ணன் சதாசிவம்