public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Don Brace <don.brace@microchip.com>
To: <don.brace@microchip.com>, <Kevin.Barnett@microchip.com>,
	<scott.teel@microchip.com>, <Justin.Lindley@microchip.com>,
	<scott.benesh@microchip.com>, <gerry.morong@microchip.com>,
	<mahesh.rajashekhara@microchip.com>, <mike.mcgowen@microchip.com>,
	<murthy.bhat@microchip.com>, <kumar.meiyappan@microchip.com>,
	<jeremy.reeves@microchip.com>, <david.strahan@microchip.com>,
	<hch@infradead.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Martin Petersen <martin.petersen@oracle.com>,
	<joseph.szczypek@hpe.com>, <POSWALD@suse.com>
Cc: <linux-scsi@vger.kernel.org>
Subject: [PATCH 0/5] smartpqi updates
Date: Thu, 11 Jul 2024 14:46:59 -0500	[thread overview]
Message-ID: <20240711194704.982400-1-don.brace@microchip.com> (raw)

These patches are based on Martin Petersen's 6.11/scsi-queue tree
  https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
  6.11/scsi-queue

The functional changes of note to smartpqi are for: multipath failover
and improving the accuracy of our RAID bypass counter.

For multipath we are:
    Reverting commit 94a68c814328 ("scsi: smartpqi: Quickly propagate path failures to SCSI midlayer")
    because under certain rare conditions involving encryption-enabled devices,
    a false path failure is reported to the SML causing multipath to failover
    to the other path.

    Improving errors returned from the driver back to the SML by checking for
    error codes returned from the firmware and returning the correct ASC/ASCQ codes
    to the SML. 

The other two patches add PCI-IDs for new controllers and change the
driver version.

This set of changes consists of:
* smartpqi-add-new-controller-PCI-IDs
  No functional changes. Just adding in more device support.
* smartpqi-improve-accuracy-of-RAID-bypass-counter
  We changed from using a integer variable to a __percpu variable. Using an integer
  was causing some race conditions when updating the "raid_bypass_cnt" value. This
  lead to unreliable results.
  Found by internal testing. No known externally reported bugs.
* smartpqi-revert-propagate-the-multipath-failure-to-SML-quickly
  We are reverting commit 94a68c814328
  ("scsi: smartpqi: Quickly propagate path failures to SCSI midlayer")
  because when encryption is enabled, a false path failure was being reported to the SML
  causing multipath to fail the path. This was because when encryption is enabled,
  the controller temporarily disables our Accelerated I/O path which caused the
  false path disabled detection. Disabling the accelerated I/O path can cause
  some performance degradation.
  Found by internal testing. No known externally reported bugs.
* smartpqi-improve-handling-of-multipath-failover
  We are better aligning error codes retuned by our controller firmware with what the OS
  is expecting. This improves multipath failover detection.
  Found by internal testing. No known externally reported bugs.
* smartpqi-update-version-to-2.1.28-025
  No functional changes.

---


David Strahan (1):
  smartpqi: add new controller PCI IDs

Don Brace (1):
  smartpqi: update driver version to 2.1.28-025

Gilbert Wu (1):
  smartpqi: revert propagate-the-multipath-failure-to-SML-quickly

Kevin Barnett (2):
  smartpqi: improve accuracy/performance of raid-bypass-counter.
  smartpqi: fix improve handling of multipath failover

 drivers/scsi/smartpqi/smartpqi.h      |   2 +-
 drivers/scsi/smartpqi/smartpqi_init.c | 176 ++++++++++++++++++++++----
 2 files changed, 151 insertions(+), 27 deletions(-)

-- 
2.45.2.827.g557ae147e6


             reply	other threads:[~2024-07-11 19:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11 19:46 Don Brace [this message]
2024-07-11 19:47 ` [PATCH 1/5] smartpqi: add new controller PCI IDs Don Brace
2024-07-11 19:47 ` [PATCH 2/5] smartpqi: improve accuracy/performance of raid-bypass-counter Don Brace
2024-07-11 19:47 ` [PATCH 3/5] smartpqi: revert propagate-the-multipath-failure-to-SML-quickly Don Brace
2024-07-11 19:47 ` [PATCH 4/5] smartpqi: fix improve handling of multipath failover Don Brace
2024-07-11 19:47 ` [PATCH 5/5] smartpqi: update driver version to 2.1.28-025 Don Brace
2024-08-03  2:12 ` [PATCH 0/5] smartpqi updates Martin K. Petersen
2024-08-05 21:17 ` Martin K. Petersen
  -- strict thread matches above, loose matches on Subject: below --
2025-04-23 18:32 Don Brace
2025-04-29  1:45 ` Martin K. Petersen
2025-05-06  4:25 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240711194704.982400-1-don.brace@microchip.com \
    --to=don.brace@microchip.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=Justin.Lindley@microchip.com \
    --cc=Kevin.Barnett@microchip.com \
    --cc=POSWALD@suse.com \
    --cc=david.strahan@microchip.com \
    --cc=gerry.morong@microchip.com \
    --cc=hch@infradead.org \
    --cc=jeremy.reeves@microchip.com \
    --cc=joseph.szczypek@hpe.com \
    --cc=kumar.meiyappan@microchip.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mahesh.rajashekhara@microchip.com \
    --cc=martin.petersen@oracle.com \
    --cc=mike.mcgowen@microchip.com \
    --cc=murthy.bhat@microchip.com \
    --cc=scott.benesh@microchip.com \
    --cc=scott.teel@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox