Re: [PATCH 6/6] scsi: sd: Do not split error messages

Damien Le Moal
2024-07-30T23:47:52Z

On 7/31/24 06:00, Bart Van Assche wrote:
> Make it easier to find these error messages with grep. This patch has been
> created as follows:
> * Delete all occurrences of the following regular expression:
> "[[:blank:]]*\\*\n[[:blank:]]*"
> * Split long lines manually where necessary.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

One nit below. With that fixed, feel free to add:

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

> @@ -2856,8 +2857,8 @@ sd_read_capacity(struct scsi_disk *sdkp, struct queue_limits *lim,
> */
> if (sdp->fix_capacity ||
> (sdp->guess_capacity && (sdkp->capacity & 0x01))) {
> - sd_printk(KERN_INFO, sdkp, "Adjusting the sector count "
> - "from its reported value: %llu\n",
> + sd_printk(KERN_INFO, sdkp,
> + "Adjusting the sector count from its reported value: %llu\n",
> (unsigned long long) sdkp->capacity);

Can you fix the alignment of the format string while at it ? No need for that
extra tab, removing it will make the line shorter.

--
Damien Le Moal
Western Digital Research