From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F225817C64 for ; Thu, 15 Aug 2024 03:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723692995; cv=none; b=AwxoGEDG8iVRZbO09sXA7I8V2adn4VAwWBeh919Ze7XQeyljFYtHoQDZbJXmuP/BKri9pSzbFLf19id/XqyJX2403hOOKqVT84PoyH78vIG+zH1IjMPFi+pq5Pm9bdE/gAlOtg9kHkNqqPxwelv5o4m5Usux3D/xEuU7pSst3B8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723692995; c=relaxed/simple; bh=VmeDJe5IiChyVSiwtUDllH7JOe3LYaNcF1sph/vs5MA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qzIdCzUyZntcolmPCBewfXIjnqri/nOJZRT4TDDrNcO6ono8AnUIFMRu7fn0qrVJQgleL12x/XMMWmSR2RfgbWUeGJg0KbyCcVeSP3uzepZdhPjeaNCYZ5+NL1S0kJ5sBEgS6Cdq5VXJr/uBwyQxVyH63xolMKd3eMeOPE6FTC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CP+i6tKx; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CP+i6tKx" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1fdd6d81812so5657725ad.1 for ; Wed, 14 Aug 2024 20:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723692993; x=1724297793; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=uz/2NgVRt2KKEiEq3hw8wd1EQ71jZ2iS/El9DiUWZbk=; b=CP+i6tKxwkcdQl6OlqNVcLTL9uvFqY5Kaiy6OUVANBInsm+0pnSFouGoXTMkadYLuI qdaLTFLyw9gwnpHxqWTN4jT7ixNFHlPOx3ihdG1yL0o5Kc8VoaFm8uJ3x+Sy/x7TYM85 ke/vaj4rhdZ7kmeR7zmo3B13u8CfsC3pnB6Ag/Ts21Na9klLVZmxNTbWPaf5QzTnWGPY xMSYpf/DtDqYx/2JzkerSfAALTjhkfbsQYyzRIwWk8vJaJGrPNNHAyQlmBfLoAoCS0to eiJ3a+LgowGT5Ug+05zswJq9OygsbSRODWCYnrFH5IZ6ZhNamMOIj2aJ9aqrd48PUzmd 7kSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723692993; x=1724297793; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uz/2NgVRt2KKEiEq3hw8wd1EQ71jZ2iS/El9DiUWZbk=; b=fm0++SrRxTk2jdilavT1rYBRS67npjgUnV2xNLI1hWBgW3yVWHSTc1INm75p9ivkvS 1Bzlqg2KnR+YVOSQYFadG13poFEXhTqJWe+8qnW8p8cXNzwfdlj+dewqpNjHjxkaj6tD dpIRFw2Q1tqdS0d446Nng6wN0XY8ngRCaSR+zGdDy93rJUJyaKZEnP9wJqdfquG3X/DU E2pYveNUOOVnDd2GYBLV+HJfzNkqW6pCj9plHipKua/XkuZC0cgSKgMZlkF4c01jGlvm ZDZAhQnWb5eoai9BM274WeENyN5pwLqGmWt7jrgN7nx+T7svN8iNi9pulnnrQUOLDlCs zCxg== X-Forwarded-Encrypted: i=1; AJvYcCWZP/w71Ym8XQBKliyAia1TplM3tIxX/Ci5hb6NTQbUwLMun+Mq5kP7XNfcWCkHOnvNGqGux6k+5hS148D/LVyClEE9ZXi5mifn0Q== X-Gm-Message-State: AOJu0YzHqw3f+OKOilESmcp5j/VUvYk3hNcM3OFFRDN1K8+FTZHOGuZy Xhwvm5ZdO+sD+PIYMGgaV147LrVyKEumZjlRWJq1b+Iq9NjafAFKDS3KG9azrA== X-Google-Smtp-Source: AGHT+IEMvWY/Z1OVulH8TSILC9neilL+JWYFVF+pUMJtaZh3B6tR9sxb+rJu6EZq+pGEBrQM/vvA5g== X-Received: by 2002:a17:902:d2c9:b0:1fb:94e2:5643 with SMTP id d9443c01a7336-201d63b3fe6mr50032115ad.12.1723692993188; Wed, 14 Aug 2024 20:36:33 -0700 (PDT) Received: from thinkpad ([36.255.17.34]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201f0319755sm3371305ad.65.2024.08.14.20.36.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 20:36:32 -0700 (PDT) Date: Thu, 15 Aug 2024 09:06:27 +0530 From: Manivannan Sadhasivam To: Bart Van Assche Cc: Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Kyoungrul Kim Subject: Re: [PATCH 1/3] ufs: core: Rename LSDB to SDBS to reflect the UFSHCI 4.0 spec Message-ID: <20240815033627.GA2562@thinkpad> References: <20240814-ufs-bug-fix-v1-0-5eb49d5f7571@linaro.org> <20240814-ufs-bug-fix-v1-1-5eb49d5f7571@linaro.org> <3e7cf9f9-abab-4249-9e7b-71f237850bdf@acm.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3e7cf9f9-abab-4249-9e7b-71f237850bdf@acm.org> On Wed, Aug 14, 2024 at 10:27:48AM -0700, Bart Van Assche wrote: > On 8/14/24 10:15 AM, Manivannan Sadhasivam via B4 Relay wrote: > > UFSHCI 4.0 spec names the 'Legacy Queue & Single Doorbell Support' field in > > Controller Capabilities register as 'SDBS'. So let's use the same > > terminology in the driver to align with the spec. > > If a rename happens, we should use the name from the spec. I found the > following in the UFSHCI 4.0 specification: "Legacy Single DoorBell Support > (LSDBS)". So please either rename SDBS into LSDBS or drop this > patch. > Hmm. I looked into the editorial version of the 4.0 spec that I got access to and that used SDBS. Maybe that got changed in the final version. Will change it to LSDBS. - Mani -- மணிவண்ணன் சதாசிவம்