From: hch <hch@lst.de>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Chris Bainbridge <chris.bainbridge@gmail.com>,
"fengli@smartx.com" <fengli@smartx.com>, hch <hch@lst.de>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [REGRESSION] critical target error, bisected
Date: Fri, 16 Aug 2024 10:06:04 +0200 [thread overview]
Message-ID: <20240816080604.GA7249@lst.de> (raw)
In-Reply-To: <whnt3t5fqae5pujt6fkg5xu6mqxc2x5llbmq6q2lclfuuafbqx@tzj3dzgb7ury>
On Fri, Aug 16, 2024 at 07:59:52AM +0000, Shinichiro Kawasaki wrote:
> I also observed a different but similar failure symptom when I ran f2fs workload
> using a zoned TCMU device. I found that the trigger is the commit f874d7210d88
> ("scsi: sd: Keep the discard mode stable") that Chris found. After the commit,
> the device has unexpected non-zero values for the sysfs attributes
> queue/discard_max_bytes and queue/discard_max_hw_bytes. I found that Martin's
> fix avoids my failure symptom also. With the fix, the failure disappeared and
> the sysfs attribute have the expected value 0. Thanks!
Btw, zoned devices in all relevant standards can support discards,
despite it being rather pointless. So we'll probably want to fix up
f2fs to handle that case correctly and not issue discards just to be on
the safe side.
next prev parent reply other threads:[~2024-08-16 8:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 14:49 [REGRESSION] critical target error, bisected Chris Bainbridge
2024-08-13 2:09 ` Martin K. Petersen
2024-08-13 2:21 ` Martin K. Petersen
2024-08-16 3:56 ` Martin K. Petersen
2024-08-16 6:08 ` Chris Bainbridge
2024-08-16 7:59 ` Shinichiro Kawasaki
2024-08-16 8:06 ` hch [this message]
2024-08-17 0:51 ` Martin K. Petersen
2024-08-16 8:21 ` John Garry
2024-08-17 0:53 ` [PATCH] scsi: sd: Do not attempt to configure discard unless LBPME is set Martin K. Petersen
2024-08-17 1:28 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816080604.GA7249@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chris.bainbridge@gmail.com \
--cc=fengli@smartx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox