From: Keith Busch <kbusch@meta.com>
To: <axboe@kernel.dk>, <hch@lst.de>, <martin.petersen@oracle.com>,
<linux-block@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
<linux-scsi@vger.kernel.org>
Cc: <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>
Subject: [PATCHv5 4/9] blk-integrity: consider entire bio list for merging
Date: Fri, 13 Sep 2024 11:28:49 -0700 [thread overview]
Message-ID: <20240913182854.2445457-5-kbusch@meta.com> (raw)
In-Reply-To: <20240913182854.2445457-1-kbusch@meta.com>
From: Keith Busch <kbusch@kernel.org>
If a bio is merged to a request, the entire bio list is merged, so don't
temporarily detach it from its list when counting segments. In most
cases, bi_next will already be NULL, so detaching is usually a no-op.
But if the bio does have a list, the current code is miscounting the
segments for the resulting merge.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
block/blk-integrity.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/block/blk-integrity.c b/block/blk-integrity.c
index afd101555d3cb..84065691aaed0 100644
--- a/block/blk-integrity.c
+++ b/block/blk-integrity.c
@@ -134,7 +134,6 @@ bool blk_integrity_merge_bio(struct request_queue *q, struct request *req,
struct bio *bio)
{
int nr_integrity_segs;
- struct bio *next = bio->bi_next;
if (blk_integrity_rq(req) == 0 && bio_integrity(bio) == NULL)
return true;
@@ -145,10 +144,7 @@ bool blk_integrity_merge_bio(struct request_queue *q, struct request *req,
if (bio_integrity(req->bio)->bip_flags != bio_integrity(bio)->bip_flags)
return false;
- bio->bi_next = NULL;
nr_integrity_segs = blk_rq_count_integrity_sg(q, bio);
- bio->bi_next = next;
-
if (req->nr_integrity_segments + nr_integrity_segs >
q->limits.max_integrity_segments)
return false;
--
2.43.5
next prev parent reply other threads:[~2024-09-13 18:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 18:28 [PATCHv5 0/9] block integrity merging and counting Keith Busch
2024-09-13 18:28 ` [PATCHv5 1/9] blk-mq: unconditional nr_integrity_segments Keith Busch
2024-09-13 18:28 ` [PATCHv5 2/9] blk-mq: set the nr_integrity_segments from bio Keith Busch
2024-09-13 18:28 ` [PATCHv5 3/9] blk-integrity: properly account for segments Keith Busch
2024-09-13 18:28 ` Keith Busch [this message]
2024-09-14 7:30 ` [PATCHv5 4/9] blk-integrity: consider entire bio list for merging Christoph Hellwig
2024-09-14 16:51 ` Keith Busch
2024-09-16 6:44 ` Christoph Hellwig
2024-09-16 8:40 ` Keith Busch
2024-09-13 18:28 ` [PATCHv5 5/9] block: provide a request helper for user integrity segments Keith Busch
2024-09-13 18:28 ` [PATCHv5 6/9] scsi: use request to get " Keith Busch
2024-09-13 18:28 ` [PATCHv5 7/9] nvme-rdma: " Keith Busch
2024-09-13 18:28 ` [PATCHv5 8/9] block: unexport blk_rq_count_integrity_sg Keith Busch
2024-09-13 18:28 ` [PATCHv5 9/9] blk-integrity: improved sg segment mapping Keith Busch
2024-09-13 18:37 ` [PATCHv5 0/9] block integrity merging and counting Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913182854.2445457-5-kbusch@meta.com \
--to=kbusch@meta.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox