Re: [PATCH 03/13] scsi: hisi_sas: Add firmware information check

kernel test robot
2024-09-26T12:20:15Z

Hi Yihang,

kernel test robot noticed the following build errors:

[auto build test ERROR on jejb-scsi/for-next]
[also build test ERROR on mkp-scsi/for-next linus/master v6.11 next-20240926]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Yihang-Li/scsi-hisi_sas-Adjust-priority-of-registering-and-exiting-debugfs-for-security/20240926-094506
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link: https://lore.kernel.org/r/20240926014332.3905399-4-liyihang9%40huawei.com
patch subject: [PATCH 03/13] scsi: hisi_sas: Add firmware information check
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240926/202409262042.MIMB8blU-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240926/202409262042.MIMB8blU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409262042.MIMB8blU-lkp@intel.com/

All errors (new ones prefixed by >>):

drivers/scsi/hisi_sas/hisi_sas_main.c: In function 'hisi_sas_shost_alloc':
>> drivers/scsi/hisi_sas/hisi_sas_main.c:2457:32: error: returning 'int' from a function with return type 'struct Scsi_Host *' makes pointer from integer without a cast [-Wint-conversion]
2457 | return error;
| ^~~~~

vim +2457 drivers/scsi/hisi_sas/hisi_sas_main.c

2424
2425 static struct Scsi_Host *hisi_sas_shost_alloc(struct platform_device *pdev,
2426 const struct hisi_sas_hw *hw)
2427 {
2428 struct resource *res;
2429 struct Scsi_Host *shost;
2430 struct hisi_hba *hisi_hba;
2431 struct device *dev = &pdev->dev;
2432 int error;
2433
2434 shost = scsi_host_alloc(hw->sht, sizeof(*hisi_hba));
2435 if (!shost) {
2436 dev_err(dev, "scsi host alloc failed\n");
2437 return NULL;
2438 }
2439 hisi_hba = shost_priv(shost);
2440
2441 INIT_WORK(&hisi_hba->rst_work, hisi_sas_rst_work_handler);
2442 hisi_hba->hw = hw;
2443 hisi_hba->dev = dev;
2444 hisi_hba->platform_dev = pdev;
2445 hisi_hba->shost = shost;
2446 SHOST_TO_SAS_HA(shost) = &hisi_hba->sha;
2447
2448 timer_setup(&hisi_hba->timer, NULL, 0);
2449
2450 if (hisi_sas_get_fw_info(hisi_hba) < 0)
2451 goto err_out;
2452
2453 if (hisi_hba->hw->fw_info_check) {
2454 error = hisi_hba->hw->fw_info_check(hisi_hba);
2455
2456 if (error)
> 2457 return error;
2458 }
2459
2460 error = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
2461 if (error) {
2462 dev_err(dev, "No usable DMA addressing method\n");
2463 goto err_out;
2464 }
2465
2466 hisi_hba->regs = devm_platform_ioremap_resource(pdev, 0);
2467 if (IS_ERR(hisi_hba->regs))
2468 goto err_out;
2469
2470 res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
2471 if (res) {
2472 hisi_hba->sgpio_regs = devm_ioremap_resource(dev, res);
2473 if (IS_ERR(hisi_hba->sgpio_regs))
2474 goto err_out;
2475 }
2476
2477 if (hisi_sas_alloc(hisi_hba)) {
2478 hisi_sas_free(hisi_hba);
2479 goto err_out;
2480 }
2481
2482 return shost;
2483 err_out:
2484 scsi_host_put(shost);
2485 dev_err(dev, "shost alloc failed\n");
2486 return NULL;
2487 }
2488

--
0-DAY CI Kernel Test Service