From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13DD53201 for ; Tue, 1 Oct 2024 06:11:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727763074; cv=none; b=Clk/PgSZDYfi4OkXZP8KRDTnM/V6P5whjk5GAbpVeKw18bv56jRowWDE3LJPd8Px/1yjtrYgwG3KI+ziqoBrMgAlmNFvXQi2dNm4FqQhEZGg3yp/D+Cp7q0DdTIkXY9n8qh9Vkvu+c/gpL/6dOssDPX17cIX0f1KO80rLCDYdWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727763074; c=relaxed/simple; bh=pr2qTEVmaZQMqPKpCQA1F7uNhDSCag5GBiG83Rfwlg4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sM/Onuh0v2Kfmj+udVOBUyjiiRIe122wjQfsvZXBmtcuETy6Uuj0cqbk7f5pOnGEFa6YXjhOKo7JJxWfMFBYiK4vAYAyeQatKi45FNGP1QvalcUQDWrrAUb0LOuyjBTwQ7V+zg5DAsArOxVJMaMihG3SLhkvUiQNn4vsgvsay74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QjA6Bk+v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QjA6Bk+v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0C1BC4CEC6; Tue, 1 Oct 2024 06:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727763073; bh=pr2qTEVmaZQMqPKpCQA1F7uNhDSCag5GBiG83Rfwlg4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QjA6Bk+vZPHIKvsyYgt+YDMzk8DOs9cpRPF/ymi65wdl6ZgC4T+2rmq3iDExZD2bs EjRV1xAj7bq9Tc1FiBPNeTVVoxpAvz5srvtd43Yq6eCCf4CTFbrR7+1m9w4fBPe6uc /UudNGfs0C7aVLw+t4GTsTex19KajBMquGP6V3sGF3A/ocnauNNr0O4dXJNs1Yu+lf /cNSkfHUs7y7FI/ESnpWq6l0pBJV1XgFLeY4x3vzxTerWQ5OEBs/QCA8BRhaN6pl4U XtW6G2qfd6aS5E2rIGO7b0ymiOt9pskxbvjFUvtun+t4fL9Nt8oq6umA2WDroz/sbJ JjefkoeUninjg== Date: Tue, 1 Oct 2024 09:11:10 +0300 From: Leon Romanovsky To: Bart Van Assche Cc: "Martin K . Petersen" , linux-scsi@vger.kernel.org, Damien Le Moal , Jason Gunthorpe , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Steffen Maier , Benjamin Block , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Adam Radford , "James E.J. Bottomley" , Khalid Aziz , Adaptec OEM Raid Solutions , Matthew Wilcox , Hannes Reinecke , Anil Gurumurthy , Sudarsana Kalluru , Saurav Kashyap , Javed Hasan , GR-QLogic-Storage-Upstream@marvell.com, Don Brace , Tyrel Datwyler , Michael Ellerman , James Smart , Dick Kennedy , Geoff Levand , Nilesh Javali , Karan Tilak Kumar , Sesidhar Baddela , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman , ching Huang , Bjorn Helgaas , Johannes Thumshirn , Soumya Negi Subject: Re: [PATCH 2/4] scsi: Convert SCSI drivers to .device_configure() Message-ID: <20241001061110.GE459313@unreal> References: <20240930201937.2020129-1-bvanassche@acm.org> <20240930201937.2020129-3-bvanassche@acm.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240930201937.2020129-3-bvanassche@acm.org> On Mon, Sep 30, 2024 at 01:18:48PM -0700, Bart Van Assche wrote: > There is agreement that the word "slave" should not be used in Linux > kernel source code. I think that "there is agreement" is over-statement. It is good thing to avoid using "slave" in the new code, but it is not a universally agreed to change old code to new naming. > Hence this patch that converts all SCSI drivers from > .slave_configure() to .device_configure(). No functionality has been > changed. > > Cc: Damien Le Moal > Signed-off-by: Bart Van Assche > --- > drivers/infiniband/ulp/srp/ib_srp.c | 5 +++-- Because of such small changes in RDMA, I'm not going to object for this patch, but my opinion is that this type of patches do more harm than benefit (for example backporting to older kernels). Thanks > drivers/message/fusion/mptfc.c | 2 +- > drivers/message/fusion/mptsas.c | 6 +++--- > drivers/message/fusion/mptscsih.c | 4 ++-- > drivers/message/fusion/mptscsih.h | 3 ++- > drivers/message/fusion/mptspi.c | 7 ++++--- > drivers/net/ethernet/allwinner/sun4i-emac.c | 4 ++-- > drivers/s390/scsi/zfcp_scsi.c | 5 +++-- > drivers/scsi/3w-9xxx.c | 7 ++++--- > drivers/scsi/3w-sas.c | 7 ++++--- > drivers/scsi/3w-xxxx.c | 9 ++++---- > drivers/scsi/53c700.c | 7 ++++--- > drivers/scsi/BusLogic.c | 7 ++++--- > drivers/scsi/BusLogic.h | 3 ++- > drivers/scsi/aacraid/linit.c | 8 ++++--- > drivers/scsi/advansys.c | 23 +++++++++++---------- > drivers/scsi/aic7xxx/aic79xx_osm.c | 4 ++-- > drivers/scsi/aic7xxx/aic7xxx_osm.c | 4 ++-- > drivers/scsi/arcmsr/arcmsr_hba.c | 8 ++++--- > drivers/scsi/bfa/bfad_im.c | 6 +++--- > drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 5 +++-- > drivers/scsi/csiostor/csio_scsi.c | 6 +++--- > drivers/scsi/esp_scsi.c | 7 ++++--- > drivers/scsi/hpsa.c | 8 ++++--- > drivers/scsi/ibmvscsi/ibmvfc.c | 7 ++++--- > drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++++--- > drivers/scsi/ips.c | 6 +++--- > drivers/scsi/ips.h | 3 ++- > drivers/scsi/lpfc/lpfc_scsi.c | 21 ++++++++++++------- > drivers/scsi/mvumi.c | 5 +++-- > drivers/scsi/myrb.c | 5 +++-- > drivers/scsi/myrs.c | 5 +++-- > drivers/scsi/ncr53c8xx.c | 5 +++-- > drivers/scsi/ps3rom.c | 5 +++-- > drivers/scsi/qedf/qedf_main.c | 5 +++-- > drivers/scsi/qla1280.c | 6 +++--- > drivers/scsi/qla2xxx/qla_os.c | 4 ++-- > drivers/scsi/qlogicpti.c | 5 +++-- > drivers/scsi/scsi_debug.c | 7 ++++--- > drivers/scsi/scsi_scan.c | 2 +- > drivers/scsi/smartpqi/smartpqi_init.c | 5 +++-- > drivers/scsi/snic/snic_main.c | 6 +++--- > drivers/scsi/stex.c | 4 ++-- > drivers/scsi/storvsc_drv.c | 5 +++-- > drivers/scsi/sym53c8xx_2/sym_glue.c | 5 +++-- > drivers/scsi/xen-scsifront.c | 7 ++++--- > drivers/staging/rts5208/rtsx.c | 4 ++-- > 47 files changed, 166 insertions(+), 124 deletions(-)