Re: [PATCH v1] mpi3mr: Validating SAS port assignments

[kernel test robot <lkp@intel.com>]

Hi Ranjan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on jejb-scsi/for-next linus/master v6.12-rc1 next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ranjan-Kumar/mpi3mr-Validating-SAS-port-assignments/20241004-173719
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link:    https://lore.kernel.org/r/20241004093140.149951-1-ranjan.kumar%40broadcom.com
patch subject: [PATCH v1] mpi3mr: Validating SAS port assignments
config: x86_64-buildonly-randconfig-004-20241005 (https://download.01.org/0day-ci/archive/20241005/202410051943.Mp9o5DlF-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410051943.Mp9o5DlF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410051943.Mp9o5DlF-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/scsi/mpi3mr/mpi3mr_transport.c:599: warning: Function parameter or struct member 'host_node' not described in 'mpi3mr_delete_sas_phy'
   drivers/scsi/mpi3mr/mpi3mr_transport.c:1046: warning: Function parameter or struct member 'port_id' not described in 'mpi3mr_get_hba_port_by_id'


vim +599 drivers/scsi/mpi3mr/mpi3mr_transport.c

fc7212fd310092 Sreekanth Reddy 2022-08-04  587  
fc7212fd310092 Sreekanth Reddy 2022-08-04  588  /**
fc7212fd310092 Sreekanth Reddy 2022-08-04  589   * mpi3mr_delete_sas_phy - Remove a single phy from port
fc7212fd310092 Sreekanth Reddy 2022-08-04  590   * @mrioc: Adapter instance reference
fc7212fd310092 Sreekanth Reddy 2022-08-04  591   * @mr_sas_port: Internal Port object
fc7212fd310092 Sreekanth Reddy 2022-08-04  592   * @mr_sas_phy: Internal Phy object
fc7212fd310092 Sreekanth Reddy 2022-08-04  593   *
fc7212fd310092 Sreekanth Reddy 2022-08-04  594   * Return: None.
fc7212fd310092 Sreekanth Reddy 2022-08-04  595   */
fc7212fd310092 Sreekanth Reddy 2022-08-04  596  static void mpi3mr_delete_sas_phy(struct mpi3mr_ioc *mrioc,
fc7212fd310092 Sreekanth Reddy 2022-08-04  597  	struct mpi3mr_sas_port *mr_sas_port,
d909d8da87f441 Ranjan Kumar    2024-10-04  598  	struct mpi3mr_sas_phy *mr_sas_phy, u8 host_node)
fc7212fd310092 Sreekanth Reddy 2022-08-04 @599  {
fc7212fd310092 Sreekanth Reddy 2022-08-04  600  	u64 sas_address = mr_sas_port->remote_identify.sas_address;
fc7212fd310092 Sreekanth Reddy 2022-08-04  601  
fc7212fd310092 Sreekanth Reddy 2022-08-04  602  	dev_info(&mr_sas_phy->phy->dev,
fc7212fd310092 Sreekanth Reddy 2022-08-04  603  	    "remove: sas_address(0x%016llx), phy(%d)\n",
fc7212fd310092 Sreekanth Reddy 2022-08-04  604  	    (unsigned long long) sas_address, mr_sas_phy->phy_id);
fc7212fd310092 Sreekanth Reddy 2022-08-04  605  
fc7212fd310092 Sreekanth Reddy 2022-08-04  606  	list_del(&mr_sas_phy->port_siblings);
fc7212fd310092 Sreekanth Reddy 2022-08-04  607  	mr_sas_port->num_phys--;
d909d8da87f441 Ranjan Kumar    2024-10-04  608  
d909d8da87f441 Ranjan Kumar    2024-10-04  609  	if (host_node) {
2745ce0e6d30e6 Sreekanth Reddy 2022-08-04  610  		mr_sas_port->phy_mask &= ~(1 << mr_sas_phy->phy_id);
d909d8da87f441 Ranjan Kumar    2024-10-04  611  
2745ce0e6d30e6 Sreekanth Reddy 2022-08-04  612  		if (mr_sas_port->lowest_phy == mr_sas_phy->phy_id)
2745ce0e6d30e6 Sreekanth Reddy 2022-08-04  613  			mr_sas_port->lowest_phy = ffs(mr_sas_port->phy_mask) - 1;
d909d8da87f441 Ranjan Kumar    2024-10-04  614  	}
fc7212fd310092 Sreekanth Reddy 2022-08-04  615  	sas_port_delete_phy(mr_sas_port->port, mr_sas_phy->phy);
fc7212fd310092 Sreekanth Reddy 2022-08-04  616  	mr_sas_phy->phy_belongs_to_port = 0;
fc7212fd310092 Sreekanth Reddy 2022-08-04  617  }
fc7212fd310092 Sreekanth Reddy 2022-08-04  618  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki